Skip to content

Empty mail notification for dismissed approvel #27035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
otbutz opened this issue Sep 12, 2023 · 2 comments · Fixed by #27063
Closed

Empty mail notification for dismissed approvel #27035

otbutz opened this issue Sep 12, 2023 · 2 comments · Fixed by #27063
Labels
type/bug

Comments

@otbutz
Copy link

otbutz commented Sep 12, 2023

Description

A mail notification triggered by an automatically dismissed review is empty:

image

Content-Type: multipart/alternative;
 boundary=7fec98bb05da73e13565f1c35ed520324672de761f3eb354ca42c4298795

--7fec98bb05da73e13565f1c35ed520324672de761f3eb354ca42c4298795
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8


--7fec98bb05da73e13565f1c35ed520324672de761f3eb354ca42c4298795
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8

<!DOCTYPE html>
<html>
<head>
	<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dutf-8">
	<title>Re: [Optitool/ot] #39395 Add freehand/lasso selection in map (#9234=
)</title>

	<style>
		blockquote { padding-left: 1em; margin: 1em 0; border-left: 1px solid gre=
y; color: #777}
		.footer { font-size:small; color:#666;}
	=09
	</style>

</head>

<body>
=09
=09
	<p>
	=09
		=09
--7fec98bb05da73e13565f1c35ed520324672de761f3eb354ca42c4298795--

(removed the mail headers which looked fine to me)

This renders as an empty page in my mail client.

Gitea Version

1.20.2

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Binary started via systemd behind a caddy reverse proxy.

Database

None
@sebastian-sauer
Copy link
Contributor

.Comment.Review.Reviewer.Name in default.tmpl is null in this case.

@sebastian-sauer
Copy link
Contributor

i'll send a pr asap to load the reviewer before sending the notification

@sebastian-sauer sebastian-sauer mentioned this issue Sep 13, 2023
Merged
techknowlogick pushed a commit that referenced this issue Sep 13, 2023
@sebastian-sauer
Load reviewer before sending notification (#27063)
e116ad4 
The
[template](https://github.com/go-gitea/gitea/blob/main/templates/mail/issue/default.tmpl#L51)
uses the Reviewer.Name property - this was not loaded.

Fixes #27035
sebastian-sauer added a commit to sebastian-sauer/gitea that referenced this issue Sep 13, 2023
@sebastian-sauer
Load reviewer before sending notification (go-gitea#27063)
b466226 
Backport go-gitea#27063

The
[template](https://github.com/go-gitea/gitea/blob/main/templates/mail/issue/default.tmpl#L51)
uses the Reviewer.Name property - this was not loaded.

Fixes go-gitea#27035
@sebastian-sauer sebastian-sauer mentioned this issue Sep 13, 2023
Merged
jolheiser pushed a commit that referenced this issue Sep 13, 2023
@sebastian-sauer
Load reviewer before sending notification (#27063) (#27064)
d8b3932 
Fixes #27035
@jpraet jpraet mentioned this issue Sep 18, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2023
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
@sebastian-sauer @earl-warren
Load reviewer before sending notification (go-gitea#27063) (go-gitea#…
3ea5384 
…27064)

Fixes go-gitea#27035

(cherry picked from commit d8b3932)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load reviewer before sending notification sebastian-sauer/gitea
3 participants
@lunny @sebastian-sauer @otbutz