Skip to content

Compare commits UI issue #28142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SimieG opened this issue Nov 20, 2023 · 0 comments · Fixed by #28182
Closed

Compare commits UI issue #28142

SimieG opened this issue Nov 20, 2023 · 0 comments · Fixed by #28182
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@SimieG
Copy link

SimieG commented Nov 20, 2023

Description

Hey, I have noticed that when you are comparing multiple commits it doesn't render the view like it does when you view a single commit. It uses the full width of the screen on the single commit view whereas the compare commits is fixed with large margins on either side.

I think it should display in the same way as the single commit view does so you see the full detail more easily.

Cheers 😉

Screenshots

image

image

Gitea Version

1.21.0

Can you reproduce the bug on the Gitea demo site?

No

Operating System

Windows

Browser Version

Edge + Chrome
@SimieG SimieG added topic/ui Change the appearance of the Gitea UI type/bug labels Nov 20, 2023
@lng2020 lng2020 mentioned this issue Nov 23, 2023
Merged
lunny pushed a commit that referenced this issue Nov 23, 2023
@lng2020 @GiteaBot
Use full width for PR comparison (#28182)
7d19337 
Follow-up #22844 
close #28142 
Before 

![ksnip_20231123-183906](https://github.com/go-gitea/gitea/assets/70063547/78428a22-b0a0-45f9-9458-7fd5ec73aa29)
After

![full](https://github.com/go-gitea/gitea/assets/70063547/047242cf-9d6c-4b3a-9f92-54102740c27e)

Co-authored-by: Giteabot <[email protected]>
@GiteaBot GiteaBot mentioned this issue Nov 23, 2023
Merged
GiteaBot added a commit to GiteaBot/gitea that referenced this issue Nov 23, 2023
@lng2020 @GiteaBot
Use full width for PR comparison (go-gitea#28182)
a2fdd64 
Follow-up go-gitea#22844 
close go-gitea#28142 
Before 

![ksnip_20231123-183906](https://github.com/go-gitea/gitea/assets/70063547/78428a22-b0a0-45f9-9458-7fd5ec73aa29)
After

![full](https://github.com/go-gitea/gitea/assets/70063547/047242cf-9d6c-4b3a-9f92-54102740c27e)

Co-authored-by: Giteabot <[email protected]>
lunny pushed a commit that referenced this issue Nov 23, 2023
@GiteaBot @lng2020
Use full width for PR comparison (#28182) (#28186)
28b8e0b 
Backport #28182 by @lng2020

Follow-up #22844 
close #28142 
Before 

![ksnip_20231123-183906](https://github.com/go-gitea/gitea/assets/70063547/78428a22-b0a0-45f9-9458-7fd5ec73aa29)
After

![full](https://github.com/go-gitea/gitea/assets/70063547/047242cf-9d6c-4b3a-9f92-54102740c27e)

Co-authored-by: Nanguan Lin <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2024
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
@lng2020 @GiteaBot @fuxiaohei
Use full width for PR comparison (go-gitea#28182)
ed2ad00 
Follow-up go-gitea#22844 
close go-gitea#28142 
Before 

![ksnip_20231123-183906](https://github.com/go-gitea/gitea/assets/70063547/78428a22-b0a0-45f9-9458-7fd5ec73aa29)
After

![full](https://github.com/go-gitea/gitea/assets/70063547/047242cf-9d6c-4b3a-9f92-54102740c27e)

Co-authored-by: Giteabot <[email protected]>
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@lng2020 @GiteaBot @silverwind
Use full width for PR comparison (go-gitea#28182)
33ceb0e 
Follow-up go-gitea#22844 
close go-gitea#28142 
Before 

![ksnip_20231123-183906](https://github.com/go-gitea/gitea/assets/70063547/78428a22-b0a0-45f9-9458-7fd5ec73aa29)
After

![full](https://github.com/go-gitea/gitea/assets/70063547/047242cf-9d6c-4b3a-9f92-54102740c27e)

Co-authored-by: Giteabot <[email protected]>
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
@GiteaBot @lng2020 @earl-warren
Use full width for PR comparison (go-gitea#28182) (go-gitea#28186)
a019cbd 
Backport go-gitea#28182 by @lng2020

Follow-up go-gitea#22844
close go-gitea#28142
Before

![ksnip_20231123-183906](https://github.com/go-gitea/gitea/assets/70063547/78428a22-b0a0-45f9-9458-7fd5ec73aa29)
After

![full](https://github.com/go-gitea/gitea/assets/70063547/047242cf-9d6c-4b3a-9f92-54102740c27e)

Co-authored-by: Nanguan Lin <[email protected]>
(cherry picked from commit 28b8e0b)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use full width for PR comparison lng2020/gitea
1 participant
@SimieG