Long package version name causes overflow #28534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

kittenswolf opened this issue Dec 19, 2023 · 2 comments · Fixed by #28619

Labels

topic/packages topic/ui type/bug

kittenswolf commented Dec 19, 2023

Description

A version name the length of a SHA1 hash (40 chars) causes an overflow in the version list.

Repro on try.gitea.io: https://try.gitea.io/kw-test/-/packages/generic/package-test/6444144e52f72414b474981ba98f6211f66dbac9

Screenshots

Gitea Version

1.21.2

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Windows 10

Browser Version

Firefox 120.0.1 (64-Bit)

kittenswolf added topic/ui type/bug labels

KN4CK3R added the topic/packages label

Contributor

me-heer commented Dec 27, 2023

Hi, can I work on this?

Member

delvh commented Dec 27, 2023

sure

me-heer mentioned this issue

Fix long package version names overflowing #28619

Merged

lunny closed this as completed in #28619

lunny pushed a commit that referenced this issue


          Fix long package version names overflowing (#28619)

3d47411

Fixes #28534 

---
Before:

![image](https://github.com/go-gitea/gitea/assets/50193156/b229551c-0a7d-4a99-9553-1f11b994876a)


After:
<img width="304" alt="image"
src="https://github.com/go-gitea/gitea/assets/50193156/53d04ad0-6d5c-47e2-8a7d-30a4d5dd9959">


Should we also apply this for long filenames in Assets?
It looks like this currently:
<img width="285" alt="image"
src="https://github.com/go-gitea/gitea/assets/50193156/e2dcbb2e-30d5-4e35-b304-6274ef60bda7">

---------

Co-authored-by: Mihir <[email protected]>

fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue


          Fix long package version names overflowing (go-gitea#28619)

2a0ba30

Fixes go-gitea#28534 

---
Before:

![image](https://github.com/go-gitea/gitea/assets/50193156/b229551c-0a7d-4a99-9553-1f11b994876a)


After:
<img width="304" alt="image"
src="https://github.com/go-gitea/gitea/assets/50193156/53d04ad0-6d5c-47e2-8a7d-30a4d5dd9959">


Should we also apply this for long filenames in Assets?
It looks like this currently:
<img width="285" alt="image"
src="https://github.com/go-gitea/gitea/assets/50193156/e2dcbb2e-30d5-4e35-b304-6274ef60bda7">

---------

Co-authored-by: Mihir <[email protected]>

github-actions bot locked as resolved and limited conversation to collaborators

silverwind pushed a commit to silverwind/gitea that referenced this issue


          Fix long package version names overflowing (go-gitea#28619)

037081f

Fixes go-gitea#28534 

---
Before:

![image](https://github.com/go-gitea/gitea/assets/50193156/b229551c-0a7d-4a99-9553-1f11b994876a)


After:
<img width="304" alt="image"
src="https://github.com/go-gitea/gitea/assets/50193156/53d04ad0-6d5c-47e2-8a7d-30a4d5dd9959">


Should we also apply this for long filenames in Assets?
It looks like this currently:
<img width="285" alt="image"
src="https://github.com/go-gitea/gitea/assets/50193156/e2dcbb2e-30d5-4e35-b304-6274ef60bda7">

---------

Co-authored-by: Mihir <[email protected]>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.