accountlinks.tmpl: nil pointer evaluating oauth2.Provider.IconHTML

[cyclane]

Description

Description and suspected cause

It is possible to get a nil pointer for $providerData in accountlinks.tmpl. This then results in an error like:

An error occurred:

Render failed, failed to render template: user/settings/security/security, error: template error: builtin(bindata):user/settings/security/accountlinks:32:20 : executing "user/settings/security/accountlinks" at <$providerData.IconHTML>: nil pointer evaluating oauth2.Provider.IconHTML
----------------------------------------------------------------------
					{{$providerData.IconHTML 20}}
					               ^
----------------------------------------------------------------------

I haven't exactly figured out how to replicate this yet, but will investigate it myself. Just created the issue to keep track of my investigation into this.

Probably something to do with an error that is ignored here

Gitea Version

1.21.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response
Relevant logs are in description (they're short).

Screenshots

Git Version

2.40.1

Operating System

gitea/gitea Docker image on virtual Debian 12 host.

How are you running Gitea?

Unmodified gitea/gitea Docker image running on a virtual Debian 12 host with a mariadb 10 database.

Database

MySQL/MariaDB

[KN4CK3R]

I think it's related to #27798. The (old) problem was a deactivated provider is missed in the list but that should be fixed.

[cyclane]

@KN4CK3R Thank you, I just tested nightly and the issue has been fixed there, so you're probably right.

[KN4CK3R]

Oh, the fix was not backported. That explains why you get that error in the last release.

[mihkel]

Should be fixed in 1.22?

[lunny]

Closed by #29263