Unable to open checker on windows #29509
Labels
Comments
|
I think the problem may be that Windows can't handle signals like Linux does, but in reality, the checker is working correctly. In Linux, the exit code is 9, which corresponds to the signal "kill". However, in Windows, it always returns 1.
|
|
Hmm .... I have question for that code long time ago (#19006 (comment)) But I don't have Windows environment at the moment .... if the code could be refactored and improved, I could help to review & approve. |
lunny
pushed a commit
that referenced
this issue
Mar 2, 2024
#29538) Close #29509 Windows, unlike Linux, does not have signal-specified exit codes. Therefore, we should add a Windows-specific check for Windows. If we don't do this, the logs will always show a failed status, even though the command actually works correctly. If you check the Go source code in exec_windows.go, you will see that it always returns exit code 1.  The exit code 1 does not exclusively signify a SIGNAL KILL; it can indicate any issue that occurs when a program fails.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
#29349 (comment)
Gitea Version
1.21.7
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
run binary
Database
None
The text was updated successfully, but these errors were encountered: