Skip to content

Show "_comment" of composer.json #30075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thojo0 opened this issue Mar 25, 2024 · 4 comments
Closed

Show "_comment" of composer.json #30075

thojo0 opened this issue Mar 25, 2024 · 4 comments
Labels
topic/packages type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@thojo0
Copy link

thojo0 commented Mar 25, 2024

Feature Description

Show the content of "_comment" from composer.json on the package page.

https://getcomposer.org/doc/04-schema.md#-comment

Screenshots

No response
@thojo0 thojo0 added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Mar 25, 2024
@KN4CK3R
Copy link
Member

KN4CK3R commented Apr 5, 2024

Does Packagist show these comments? If yes, could you link an example package?

@lunny lunny changed the title Show "_comment" of conposer.json Show "_comment" of composer.json Apr 6, 2024
@thojo0
Copy link
Author

thojo0 commented Apr 10, 2024

_comment doesn't get used, but the README so I think the README would be the better option.
Just look at almost any project on Packagist for the README:
Example: laravel/laravel
Maybe just show the README of the linked repository.

@KN4CK3R
Copy link
Member

KN4CK3R commented Apr 10, 2024

Already have a branch ready which reads the readme file too. Will create a PR soon.

@thojo0
Copy link
Author

thojo0 commented Apr 10, 2024

I will close this as 'not planned' because README is the better option.

@thojo0 thojo0 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
@KN4CK3R KN4CK3R mentioned this issue May 9, 2024
Merged
lunny pushed a commit that referenced this issue Jun 14, 2024
@KN4CK3R
Extract and display readme and comments for Composer packages (#30927)
4e7b067 
Related #30075

CC @thojo0

Example with rendered readme:

![grafik](https://github.com/go-gitea/gitea/assets/1666336/3516fef5-2631-40fd-8841-5d9894ec8904)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/packages type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lunny @KN4CK3R @thojo0