Skip to content

Bad ui in mobile view when the language is not english #31071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yp05327 opened this issue May 24, 2024 · 6 comments · Fixed by #31091
Closed

Bad ui in mobile view when the language is not english #31071

yp05327 opened this issue May 24, 2024 · 6 comments · Fixed by #31091
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@yp05327
Copy link
Contributor

yp05327 commented May 24, 2024

Description

in english: (not too bad)
IMG_3912

in other language:
IMG_3911

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

gitea.com

Database

None
@yp05327 yp05327 added type/bug topic/ui Change the appearance of the Gitea UI labels May 24, 2024
@silverwind
Copy link
Member

You mean remove the "Normal File" to make space for filename?

@yp05327
Copy link
Contributor Author

yp05327 commented May 24, 2024 •
edited
Loading

This is what GitHub looks like:
image

@silverwind
Copy link
Member

silverwind commented May 24, 2024 •
edited
Loading

Multiline layout is likely a good idea here to show a sufficient amount of filename characters.

silverwind added a commit to silverwind/gitea that referenced this issue May 26, 2024
@silverwind
Improve mobile review ui
e35679d 
Fixes: go-gitea#31071
@silverwind silverwind mentioned this issue May 27, 2024
Merged
@yp05327
Copy link
Contributor Author

yp05327 commented May 28, 2024

IMG_3956

a new problem

@silverwind
Copy link
Member

IMG_3956

a new problem

Already fixed this overflow in #31091, if you give it a try.

@yp05327
Copy link
Contributor Author

yp05327 commented May 28, 2024

I think maybe you have already fixed it, so I reported it here. 😄

lunny pushed a commit that referenced this issue May 28, 2024
@silverwind
Improve mobile review ui (#31091)
1e3c4d8 
Fixes: #31071

Not perfect but much better than before.

Before: Overflows, sticky not working, filename unreadable:

<img width="506" alt="Screenshot 2024-05-27 at 02 02 40"
src="https://github.com/go-gitea/gitea/assets/115237/a06b1edf-dece-4402-98c2-68670fca265f">

After:
<img width="457" alt="Screenshot 2024-05-27 at 01 59 06"
src="https://github.com/go-gitea/gitea/assets/115237/2a282c96-e719-4554-b418-81963ae6269c">
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue May 28, 2024
@silverwind @GiteaBot
Improve mobile review ui (go-gitea#31091)
0a5c761 
Fixes: go-gitea#31071

Not perfect but much better than before.

Before: Overflows, sticky not working, filename unreadable:

<img width="506" alt="Screenshot 2024-05-27 at 02 02 40"
src="https://github.com/go-gitea/gitea/assets/115237/a06b1edf-dece-4402-98c2-68670fca265f">

After:
<img width="457" alt="Screenshot 2024-05-27 at 01 59 06"
src="https://github.com/go-gitea/gitea/assets/115237/2a282c96-e719-4554-b418-81963ae6269c">
@GiteaBot GiteaBot mentioned this issue May 28, 2024
Merged
lunny pushed a commit that referenced this issue May 28, 2024
@GiteaBot @silverwind
Improve mobile review ui (#31091) (#31136)
b615a59 
Backport #31091 by @silverwind

Fixes: #31071

Not perfect but much better than before.

Before: Overflows, sticky not working, filename unreadable:

<img width="506" alt="Screenshot 2024-05-27 at 02 02 40"
src="https://github.com/go-gitea/gitea/assets/115237/a06b1edf-dece-4402-98c2-68670fca265f">

After:
<img width="457" alt="Screenshot 2024-05-27 at 01 59 06"
src="https://github.com/go-gitea/gitea/assets/115237/2a282c96-e719-4554-b418-81963ae6269c">

Co-authored-by: silverwind <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 26, 2024
richmahn pushed a commit to unfoldingWord/dcs that referenced this issue Mar 2, 2025
@silverwind @richmahn
Improve mobile review ui (#31091)
a7bfa34 
Fixes: go-gitea/gitea#31071

Not perfect but much better than before.

Before: Overflows, sticky not working, filename unreadable:

<img width="506" alt="Screenshot 2024-05-27 at 02 02 40"
src="https://github.com/go-gitea/gitea/assets/115237/a06b1edf-dece-4402-98c2-68670fca265f">

After:
<img width="457" alt="Screenshot 2024-05-27 at 01 59 06"
src="https://github.com/go-gitea/gitea/assets/115237/2a282c96-e719-4554-b418-81963ae6269c">
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve mobile review ui silverwind/gitea
2 participants
@silverwind @yp05327