Skip to content

[Bug] Activity Page Contributors - type dropdown breaks non-English locale #31261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snoweuph opened this issue Jun 5, 2024 · 2 comments · Fixed by #31264
Closed

[Bug] Activity Page Contributors - type dropdown breaks non-English locale #31261

snoweuph opened this issue Jun 5, 2024 · 2 comments · Fixed by #31264
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@snoweuph
Copy link

snoweuph commented Jun 5, 2024 •
edited
Loading

Description

When changing the Display Language to German in the Gitea Footer and trying to change the type in the contributors tab, from commits to any of the other ones, they don't get select and just end up empty.

Gitea Version

1.22.0

Can you reproduce the bug on the Gitea demo site?

Yes: https://gitea.com/Dominik_Saeume/nhplus/activity/contributors

Screenshots

image

How are you running Gitea?

https://demo.gitea.com/
@snoweuph snoweuph changed the title Drop in Activity Page - Contributors type selection breaks with ä and ö [Bug] Activity Page Contributors - type dropdown breaks with ä and ö Jun 5, 2024
@silverwind silverwind added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jun 5, 2024
@wxiaoguang wxiaoguang changed the title [Bug] Activity Page Contributors - type dropdown breaks with ä and ö [Bug] Activity Page Contributors - type dropdown breaks non-English locale Jun 5, 2024
@wxiaoguang
Copy link
Contributor

Actually, it breaks in all languages other than English. It is a code-level bug.

@wxiaoguang wxiaoguang mentioned this issue Jun 5, 2024
Merged
@wxiaoguang
Copy link
Contributor

-> Fix Activity Page Contributors dropdown #31264

wxiaoguang added a commit that referenced this issue Jun 6, 2024
@wxiaoguang
Fix Activity Page Contributors dropdown (#31264)
e728fd7 
Fix #31261
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jun 6, 2024
@wxiaoguang @GiteaBot
Fix Activity Page Contributors dropdown (go-gitea#31264)
ca736c5 
Fix go-gitea#31261
@GiteaBot GiteaBot mentioned this issue Jun 6, 2024
Merged
wxiaoguang added a commit that referenced this issue Jun 6, 2024
@GiteaBot @wxiaoguang
Fix Activity Page Contributors dropdown (#31264) (#31269)
c07416b 
Backport #31264 by wxiaoguang

Fix #31261

Co-authored-by: wxiaoguang <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 4, 2024
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
@wxiaoguang
Fix Activity Page Contributors dropdown (go-gitea#31264)
7b443b6 
Fix go-gitea#31261

(cherry picked from commit e728fd7)
(cherry picked from commit 3544746)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Activity Page Contributors dropdown wxiaoguang/gitea
3 participants
@silverwind @wxiaoguang @snoweuph