Skip to content

Gitea always shows close button when I clicked multi select checkbox in issue list #32080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cloudchamb3r opened this issue Sep 19, 2024 · 0 comments · Fixed by #32081
Closed
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone

Comments

@cloudchamb3r
Copy link
Contributor

cloudchamb3r commented Sep 19, 2024

Description

Thanks to @sangcheol12 and @Lieslot I found some UI bug.
When I check the multi-select checkbox in the issues list, the close button is always shown, even though I have selected closed issues.
This problem also occurs in pull requests list, because they share same logic.

This branch has a fix for this issue.

Screenshots

opened issues

Screenshot 2024-09-19 at 6 04 48 PM

closed issues

Screenshot 2024-09-19 at 6 04 55 PM

Gitea Version

1.22

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

OSX Sonoma

Browser Version

Chrome 129.0.6668.58

@cloudchamb3r cloudchamb3r added topic/ui Change the appearance of the Gitea UI type/bug labels Sep 19, 2024
@cloudchamb3r cloudchamb3r changed the title Gitea always shows closed button when I clicked multi select checkbox in issue list Gitea always shows close button when I clicked multi select checkbox in issue list Sep 19, 2024
@lunny lunny added this to the 1.22.3 milestone Sep 19, 2024
@lunny lunny closed this as completed in e1f0598 Sep 23, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Sep 23, 2024
fix go-gitea#32080

## After 
### for opened issues 
<img width="1199" alt="Screenshot 2024-09-19 at 6 29 31 PM"
src="https://github.com/user-attachments/assets/86cf48ad-5e4b-4dcb-8abe-4d7fd74e0aec">

### for closed issues 
<img width="1208" alt="Screenshot 2024-09-19 at 6 29 37 PM"
src="https://github.com/user-attachments/assets/a16bc545-bfcf-49a4-be52-3e7334910482">

### for all issues
<img width="1340" alt="Screenshot 2024-09-20 at 12 07 12 PM"
src="https://github.com/user-attachments/assets/b2309c8f-e59d-44e9-ae3b-bf54e1196169">
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 22, 2024
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
fix go-gitea#32080

## After
### for opened issues
<img width="1199" alt="Screenshot 2024-09-19 at 6 29 31 PM"
src="https://github.com/user-attachments/assets/86cf48ad-5e4b-4dcb-8abe-4d7fd74e0aec">

### for closed issues
<img width="1208" alt="Screenshot 2024-09-19 at 6 29 37 PM"
src="https://github.com/user-attachments/assets/a16bc545-bfcf-49a4-be52-3e7334910482">

### for all issues
<img width="1340" alt="Screenshot 2024-09-20 at 12 07 12 PM"
src="https://github.com/user-attachments/assets/b2309c8f-e59d-44e9-ae3b-bf54e1196169">

(cherry picked from commit e1f0598)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants