Skip to content

Show Stats does nothing #32226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kuraga opened this issue Oct 9, 2024 · 5 comments · Fixed by #32244
Closed

Show Stats does nothing #32226

kuraga opened this issue Oct 9, 2024 · 5 comments · Fixed by #32244
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.22.4

Comments

@kuraga
Copy link

kuraga commented Oct 9, 2024 •
edited
Loading

Description

No response

Screenshots

  1. Go to https://demo.gitea.com/kuraga/test/pulls/3/files

image

  1. Click ... (Diff Options).
  2. Click Show Stats.
  3. Nothing happened?

image

  1. Show Stats went gray.
  2. Click Show Stats.
  3. Nothing happened?
  4. Click ... (Diff Options).
  5. Show Stats didn't switch back from gray.

image

Gitea Version

1.23.0+dev-534-gf4b8f6fc40

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Calculate Linux (Gentoo-based)

Browser Version

129.0.6668.89 (Official build), (64 bit)
@kuraga kuraga added topic/ui Change the appearance of the Gitea UI type/bug labels Oct 9, 2024
@wxiaoguang

This comment was marked as outdated.

Sign in to view
@wxiaoguang wxiaoguang added issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change and removed issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change labels Oct 9, 2024
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Oct 9, 2024 •
edited
Loading

OK, not really a regression:

  • If the PR only contains one changed file, then the left tree & stats won't show
  • If the PR contains more than one changed files, then the left tree & stats will show

Well, a strange UI design.

https://demo.gitea.com/wxiaoguang/test1/pulls/3/files

https://demo.gitea.com/wxiaoguang/test1/pulls/4/files

image

image

@kuraga
Copy link
Author

kuraga commented Oct 9, 2024

...and non-un-highlighting Show Stats...

@wxiaoguang
Copy link
Contributor

...and non-un-highlighting Show Stats...

Yup, that's another UI problem. Not only Show Stats, most items in a dropdrown which don't refresh the page would have the same problem.

a1012112796 added a commit to a1012112796/gitea that referenced this issue Oct 12, 2024
@a1012112796
make show stats work when only one file changed
a075094 
fix go-gitea#32226

in go-gitea#27775 ,
it do some changes to only show diff file tree when more than one
file changed. But looks it also break the `diff-file-list` logic,
which looks not expected change. so try fix it.

/cc @silverwind

Signed-off-by: a1012112796 <[email protected]>
@a1012112796 a1012112796 mentioned this issue Oct 12, 2024
Merged
@lunny lunny added this to the 1.22.4 milestone Oct 12, 2024
@lunny lunny closed this as completed in c4b2808 Oct 14, 2024
@kuraga
Copy link
Author

kuraga commented Oct 15, 2024

Thanks!

a1012112796 added a commit to a1012112796/gitea that referenced this issue Oct 15, 2024
@a1012112796
make show stats work when only one file changed (go-gitea#32244)
bcd4bdf 
Backport go-gitea#32244

fix go-gitea#32226

in go-gitea#27775 , it do some changes to
only show diff file tree when more than one file changed. But looks it
also break the `diff-file-list` logic, which looks not expected change.
so try fix it.

/cc @silverwind

example view:

![image](https://github.com/user-attachments/assets/281e9c4f-a269-4d36-94eb-a132058aea87)

Signed-off-by: a1012112796 <[email protected]>
@a1012112796 a1012112796 mentioned this issue Oct 15, 2024
Merged
lunny pushed a commit that referenced this issue Oct 17, 2024
@a1012112796
make show stats work when only one file changed (#32244) (#32268)
2a99607 
Backport #32244

fix #32226

in #27775 , it do some changes to
only show diff file tree when more than one file changed. But looks it
also break the `diff-file-list` logic, which looks not expected change.
so try fix it.

/cc @silverwind

example view:

![image](https://github.com/user-attachments/assets/281e9c4f-a269-4d36-94eb-a132058aea87)

Signed-off-by: a1012112796 <[email protected]>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Oct 22, 2024
@a1012112796 @algernon
make show stats work when only one file changed (#32244)
3aaf6f7 
fix go-gitea/gitea#32226

in go-gitea/gitea#27775 , it do some changes to
only show diff file tree when more than one file changed. But looks it
also break the `diff-file-list` logic, which looks not expected change.
so try fix it.

/cc @silverwind

example view:

![image](https://github.com/user-attachments/assets/281e9c4f-a269-4d36-94eb-a132058aea87)

Signed-off-by: a1012112796 <[email protected]>
(cherry picked from commit c4b2808b896dd86323c6a0d119c8cf24752d4d8a)
Signed-off-by: Gergely Nagy <[email protected]>

Conflicts:
	- web_src/js/features/repo-diff-filetree.js
	  web_src/js/features/repo-diff.js
	  Conflicts resolved by manually applying the changes.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 12, 2025
richmahn pushed a commit to unfoldingWord/dcs that referenced this issue Mar 2, 2025
@a1012112796 @richmahn
make show stats work when only one file changed (#32244)
e8713a8 
fix go-gitea/gitea#32226

in go-gitea/gitea#27775 , it do some changes to
only show diff file tree when more than one file changed. But looks it
also break the `diff-file-list` logic, which looks not expected change.
so try fix it.

/cc @silverwind 

example view:

![image](https://github.com/user-attachments/assets/281e9c4f-a269-4d36-94eb-a132058aea87)

Signed-off-by: a1012112796 <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.22.4
Development

Successfully merging a pull request may close this issue.

make show stats work when only one file changed a1012112796/gitea
3 participants
@lunny @kuraga @wxiaoguang