Skip to content

Unified primary button colors #32871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
silverwind opened this issue Dec 17, 2024 · 5 comments · Fixed by #32949
Closed

Unified primary button colors #32871

silverwind opened this issue Dec 17, 2024 · 5 comments · Fixed by #32949
Labels
topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@silverwind
Copy link
Member

silverwind commented Dec 17, 2024

Currently we are inconsistent with primary buttons. Code button is green, merge button and new issue button are primary.

Screenshot 2024-12-17 at 05 59 29 Screenshot 2024-12-17 at 05 59 46 Screenshot 2024-12-17 at 05 59 37

I feel like all primary buttons should be the same color. The easiest way would be to make the code button primary as well. Or we do it like GitHub and make primary buttons green (diverging from primary links which are blue). I'm undecided whether green or primary (default blue) would be better.

@silverwind silverwind added type/proposal The new feature has not been accepted yet but needs to be discussed first. topic/ui Change the appearance of the Gitea UI labels Dec 17, 2024
@silverwind silverwind changed the title Unified button colors Unified primary button colors Dec 17, 2024
@hiifong
Copy link
Member

hiifong commented Dec 17, 2024

To be honest, I prefer green

@wxiaoguang
Copy link
Contributor

To be honest, I prefer green

GitHub uses green because its primary color is green.

Gitea's primary color is blue.

@lunny
Copy link
Member

lunny commented Dec 18, 2024

So maybe change it to blue?

Using green as the primary button color for Gitea could clash with its green logo, making the interface feel monotonous. Blue provides a complementary contrast, helping buttons stand out clearly while maintaining a balanced design. GitHub uses green buttons because its black logo allows for contrast; for Gitea, blue achieves a similar effect.

@xxfogs
Copy link

xxfogs commented Dec 22, 2024

"Sync fork" too should use primary

image

If primary is in use for buttons, the theme can be adjusted to anyone's preferences

@wxiaoguang
Copy link
Contributor

-> Use primary as button color #32949

wxiaoguang added a commit that referenced this issue Dec 22, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Dec 22, 2024
wxiaoguang added a commit that referenced this issue Dec 22, 2024
Backport #32949 by wxiaoguang

* Fix #32871
* Fix #32948

Co-authored-by: wxiaoguang <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants