Skip to content

Panic in createIssueComment() #32897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hwaastad opened this issue Dec 18, 2024 · 1 comment · Fixed by #32901
Closed

Panic in createIssueComment() #32897

hwaastad opened this issue Dec 18, 2024 · 1 comment · Fixed by #32901
Labels

Comments

@hwaastad
Copy link

Description

adding label creates panic.
code being run (cloudforet-io/check-pr-action@v1):

await octokit.rest.issues.addLabels({
        ...context.repo,
        issue_number: context.issue.number,
        labels: ['fail/signedoff']
})

gitea logs:

2024/12/18 20:50:01 ...eb/routing/logger.go:78:func1() [W] router: failed    POST /api/v1/repos/My-Organization/actions-repo-2/issues/43/comments for 10.42.3.118:57880, panic in 64.4ms @ repo/issue_comment.go:343(repo.CreateIssueComment), err=runtime error: invalid memory address or nil pointer dereference
2024-12-18T20:50:01.347079787Z 2024/12/18 20:50:01 ...rs/common/errpage.go:26:RenderPanicErrorPage() [E] PANIC: runtime error: invalid memory address or nil pointer dereference
2024-12-18T20:50:01.347096769Z /usr/local/go/src/runtime/panic.go:785 (0x479711)
2024-12-18T20:50:01.347101655Z /go/src/code.gitea.io/gitea/modules/web/routing/logger_manager.go:116 (0x1ebd788)
2024-12-18T20:50:01.347107237Z /usr/local/go/src/runtime/panic.go:785 (0x479711)
2024-12-18T20:50:01.347111343Z /usr/local/go/src/runtime/panic.go:262 (0x47bb98)
2024-12-18T20:50:01.347116004Z /usr/local/go/src/runtime/signal_unix.go:917 (0x47bb68)
2024-12-18T20:50:01.347121048Z /go/src/code.gitea.io/gitea/services/convert/pull.go:34 (0x2078ee9)
2024-12-18T20:50:01.347125478Z /go/src/code.gitea.io/gitea/services/webhook/notifier.go:413 (0x2afa59c)
2024-12-18T20:50:01.347130370Z /go/src/code.gitea.io/gitea/services/notify/notify.go:53 (0x1fe1568)
2024-12-18T20:50:01.347134649Z /go/src/code.gitea.io/gitea/services/issue/comments.go:79 (0x1fe14d1)
2024-12-18T20:50:01.347161005Z /go/src/code.gitea.io/gitea/routers/api/v1/repo/issue_comment.go:399 (0x2b86a3a)
2024-12-18T20:50:01.347166199Z /usr/local/go/src/reflect/value.go:581 (0x507845)
2024-12-18T20:50:01.347170505Z /usr/local/go/src/reflect/value.go:365 (0x506958)
2024-12-18T20:50:01.347174891Z /go/src/code.gitea.io/gitea/modules/web/handler.go:172 (0x1ec721c)
2024-12-18T20:50:01.347179615Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347184328Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347188619Z /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1ec72bb)
2024-12-18T20:50:01.347192669Z /usr/local/go/sr
(0x97ed68)
2024-12-18T20:50:01.347196691Z /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1ec72bb)
2024-12-18T20:50:01.347200953Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347205262Z /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1ec72bb)
2024-12-18T20:50:01.347209732Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347213629Z /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1ec72bb)
2024-12-18T20:50:01.347217475Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347221642Z /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1ec72bb)
2024-12-18T20:50:01.347225744Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347229886Z /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1ec72bb)
/usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347238915Z /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1ec72bb)
2024-12-18T20:50:01.347242921Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347247454Z /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1ec72bb)
2024-12-18T20:50:01.347251913Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347256884Z /go/pkg/mod/github.com/go-chi/chi/[email protected]/chain.go:31 (0x1ebe065)
2024-12-18T20:50:01.347262289Z /go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:459 (0x1ec1001)
2024-12-18T20:50:01.347265165Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347267867Z /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1ec72bb)
2024-12-18T20:50:01.347270692Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347273302Z /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1ec72bb)
2024-12-18T20:50:01.347275965Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347278617Z /go/src/code.gitea.io/gitea/modules/web/handler.go:182 (0x1ec72bb)
2024-12-18T20:50:01.347281496Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347289570Z /go/src/code.gitea.io/gitea/services/context/api.go:238 (0x2c015fa)
2024-12-18T20:50:01.347292452Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347295104Z /go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1ec76b9)
/usr/local/go/src/net/http/server.go:2220 (0x97ed68)
/go/src/code.gitea.io/gitea/routers/api/v1/api.go:1665 (0x2c01196)
2024-12-18T20:50:01.347303243Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347305830Z /go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1ec76b9)
/usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347311276Z /go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:73 (0x1ebec0e)
/go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:327 (0x1ec059a)
2024-12-18T20:50:01.347319891Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347324107Z /go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:459 (0x1ec1001)
/usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347333137Z /go/src/code.gitea.io/gitea/modules/web/routing/logger_manager.go:122 (0x1ebd618)
/usr/local/go/src/net/http/server.go:2220 (0x97ed68)
/go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1ec76b9)
2024-12-18T20:50:01.347346345Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347350657Z /go/pkg/mod/github.com/chi-middleware/[email protected]/middleware.go:37 (0x2b52fd3)
2024-12-18T20:50:01.347354829Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
/go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1ec76b9)
2024-12-18T20:50:01.347362163Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347366276Z /go/src/code.gitea.io/gitea/routers/common/middleware.go:59 (0x2b541af)
2024-12-18T20:50:01.347370070Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347374053Z /go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1ec76b9)
2024-12-18T20:50:01.347379508Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347383317Z /go/src/code.gitea.io/gitea/routers/common/middleware.go:50 (0x2b53d3b)
/usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347391100Z /go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1ec76b9)
/usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347399333Z /go/src/code.gitea.io/gitea/routers/common/middleware.go:36 (0x2b53969)
/usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347415228Z /go/src/code.gitea.io/gitea/modules/web/handler.go:136 (0x1ec76b9)
2024-12-18T20:50:01.347419496Z /usr/local/go/src/net/http/server.go:2220 (0x97ed68)
2024-12-18T20:50:01.347423392Z /go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:90 (0x1ebebcd)
/go/src/code.gitea.io/gitea/modules/web/route.go:237 (0x1ec91bb)
2024-12-18T20:50:01.347446896Z /go/src/code.gitea.io/gitea/modules/web/route.go:175 (0x1ec8b64)
2024-12-18T20:50:01.347451438Z /usr/local/go/src/net/http/server.go:3210 (0x99f2cd)
2024-12-18T20:50:01.347456106Z /usr/local/go/src/net/http/server.go:2092 (0x97d70f)
2024-12-18T20:50:01.347458812Z /usr/local/go/src/runtime/asm_amd64.s:1700 (0x482120)

Gitea Version

1.23.0-rc0

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker (k8s)

Database

MySQL/MariaDB

@hwaastad
Copy link
Author

It works and not works.
Output from action:

Successfull on pass/signedoff:

::warning::Found: 1 total commits
 e[2](https://giteaserver/My-Organization/actions-repo-2/actions/runs/105#jobstep-1-2)d2ea: Update .gitea/workflows/on-workflow-dispatch.yaml
All commits have a valid signed-off-by

On fail/signedoff:

:warning::Found: 1 total commits
 1[2](https://giteaserver/My-Organization/actions-repo-2/actions/runs/108#jobstep-1-2)047e: Update README.md
::error::%0A<!DOCTYPE html>%0A<html lang="en-US" data-theme="gitea-auto">%0A<head>%0A	<meta name="viewport" content="width=device-width, initial-scale=1">%0A	<title>Internal Server Error - gitea</title>%0A	<link rel="icon" href="/assets/img/favicon.svg" type="image/svg+xml">%0A	<link rel="alternate icon" href="/assets/img/favicon.png" type="image/png">%0A	<link rel="stylesheet" href="/assets/css/index.css?v=1.2[3](https://gitea.ompalompa.net/My-Organization/actions-repo-2/actions/runs/108#jobstep-1-3).0~rc0">%0A<link rel="stylesheet" href="/assets/css/theme-gitea-auto.css?v=1.23.0~rc0">%0A%0A</head>%0A<body>%0A	<div class="full height">%0A		<nav class="ui secondary menu">%0A			<div class="ui container tw-flex">%0A				<div class="item tw-flex-1">%0A					<a href="/" aria-label="Home">%0A						<img width="30" height="30" src="/assets/img/logo.svg" alt="Logo" aria-hidden="true">%0A					</a>%0A				</div>%0A				<div class="item">%0A					<button class="ui icon button disabled"><svg viewBox="0 0 16 16" class="svg octicon-three-bars" aria-hidden="true" width="16" height="16"><path d="M1 2.75A.75.75 0 0 1 1.75 2h12.5a.75.75 0 0 1 0 1.5H1.75A.75.75 0 0 1 1 2.75m0 5A.75.75 0 0 1 1.75 7h12.5a.75.75 0 0 1 0 1.5H1.75A.75.75 0 0 1 1 7.75M1.75 12h12.5a.75.75 0 0 1 0 1.5H1.75a.75.75 0 0 1 0-1.5"/></svg></button>%0A				</div>%0A			</div>%0A		</nav>%0A		<div class="divider tw-my-0"></div>%0A		<div role="main" class="page-content status-page-500">%0A			<div class="ui container" >%0A				<style> .ui.message.flash-message { text-align: left; } </style>%0A				%0A%0A%0A%0A%0A				<div class="status-page-error">%0A					<div class="status-page-error-title">500 Internal Server Error</div>%0A					%0A					<div class="tw-mt-8 tw-text-center">%0A						%0A						%0A					</div>%0A				</div>%0A			</div>%0A		</div>%0A	</div>%0A%0A	%0A	<script type="module">%0A		const embedded = document.querySelector('.page-content .page-content.status-page-500');%0A		if (embedded) {%0A			%0A			const embeddedParent = embedded.parentNode;%0A			let main = document.querySelector('.page-content');%0A			main = main ?? document.querySelector('body');%0A			main.prepend(document.createElement('hr'));%0A			main.prepend(embedded);%0A			embeddedParent.remove(); %0A		}%0A	</script>%0A</body>%0A</html>%0A

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant