-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
WebAuthn failure on HTTP instance with a custom domain #33615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It is the WebAuthn standard: it only works for HTTPS and So HTTPS is a must for WebAuthn But I guess we could hide the error message when users do not need it? |
The issue is I'm not trying to use WebAuthn. I'm trying to login with a basic username and password. |
-> Do not show passkey on http sites #33820 |
Fix go-gitea#33615 (cherry picked from commit b8c2afd)
Description
Tested on gitea/gitea:1.23.2 and gitea/gitea:latest.
I have this config:
However, whenever I go to the sign-in page, I get the following error:
This only happens when https was disabled. I thought it might have been something with the data in my gitea instance, or my postgres database, so I tested by recreating a gitea server on a different machine, and added a test repo. Then, once I brought all of the gitea files and the database over again (using docker, but data is stored locally), I tried logging in as localhost. Localhost worked just fine.
However, when I changed the DOMAIN, SSH_DOMAIN, and ROOT_URL, I got the security key error.
Gitea Version
1.23.2
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
https://gist.github.com/micah686/15facf90586cfe7349aeefa2fced4597
Screenshots
Git Version
2.47.2
Operating System
Host OS: Windows 10. Using gitea gitea/gitea:1.23.2 image
How are you running Gitea?
I am running windows 10, and docker desktop. I am using docker compose to spin up gitea.
Database
PostgreSQL
The text was updated successfully, but these errors were encountered: