Skip to content

Cannot delete runners via the modal dialog in user settings #33894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ChristopherHX opened this issue Mar 14, 2025 · 3 comments · Fixed by #33895
Closed

Cannot delete runners via the modal dialog in user settings #33894

ChristopherHX opened this issue Mar 14, 2025 · 3 comments · Fixed by #33895
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.24.0

Comments

@ChristopherHX
Copy link
Contributor

Description

The delete modal closes without any error, but the runner delete is never called on the backend and you do not navigate to the runner list.

This bug reproduces on both 65e2411 and the version of the demo site.

gitea.com does not have this bug, while I have no idea about what version it uses.

I have seen this bug while debugging runner rest api changes to runner deletion and then switched to main branch and the problem is still there.

Screenshots

Bildschirmaufnahme.2025-03-15.um.00.28.19.mov

Gitea Version

403775e

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

macOS

Browser Version

Microsoft Edge Version 131.0.2903.99 (Offizielles Build) (arm64)
@ChristopherHX ChristopherHX added topic/ui Change the appearance of the Gitea UI type/bug labels Mar 14, 2025
@ChristopherHX ChristopherHX mentioned this issue Mar 14, 2025
Merged
@wxiaoguang
Copy link
Contributor

gitea.com does not have this bug, while I have no idea about what version it uses.

Now gitea.com: 1.24.0~dev-431-g8c1289cf39

@wxiaoguang
Copy link
Contributor

I think the problem is that delete-button show-modal these two conflict.

Maybe related to Refactor buttons to use new init framework (#33774)

And the reason is:

Image

@wxiaoguang wxiaoguang added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Mar 15, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 15, 2025
@wxiaoguang wxiaoguang added the issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change label Mar 15, 2025
@ChristopherHX ChristopherHX mentioned this issue Mar 15, 2025
Merged
@ChristopherHX
Copy link
Contributor Author

Thank you for the hint, removing show-modal class seems to resolve this for me

@lunny lunny closed this as completed in 7e8168f Mar 15, 2025
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Apr 1, 2025
@ChristopherHX @Gusted
Fix cannot delete runners via the modal dialog (go-gitea#33895)
4ba5c95 
delete-button and show-modal class are conflicting

Closes go-gitea#33894

(cherry picked from commit 7e8168f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

Fix cannot delete runners via the modal dialog ChristopherHX/gitea
2 participants
@wxiaoguang @ChristopherHX