Broken render of some SVGs in diff page

[didim99]

Description

Some SVGs rendered as empty line in commit/PR/diff page, but at file view page shows as expected. I have no idea what the difference, but this behaviour affects many our custom SVGs exported form Adobe Illustrator. See example at this PR: https://demo.gitea.com/didim99/test/pulls/6/files
File nonascii.svg rendered as expected, but off.svg is broken. off.svg is rendered normally on file view page: https://demo.gitea.com/didim99/test/src/branch/svg-test/svg/off.svg

Gitea Version

1.24.4 to 1.26.0+dev-105-g685c8c314f

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Git Version

Not matters

Operating System

Not matters

How are you running Gitea?

Using demo.gitea.com, self-hosted

Database

None

[silverwind]

It does render both SVGs correctly currently on that link for me.

BTW there is a known issue that SVGs without xmlns don't render, but I see that is not the problem with these.

[wxiaoguang]

Also render for me.

[didim99]

@wxiaoguang it seems to be browser-dependent issue, so I do some research about this:

• The first screenshot (call it "variant 1") was taken from Firefox 136 on Ubuntu 20.04 (my daily work setup)
• In Chrome 140.0.7339.207 on Ubuntu the issue remains, but looks different (call it "variant 2"):
  
• After updating Chrome to last available version 142.0.7444.59 on my Ubuntu the both SVGs rendered correctly
• In more recent version of Firefox (144.0) on Ubuntu 24.04 both rendered correctly
• For Windows 10 (Build 19045):
  • In Opera One 123.0.5669.23 (based on Chromium 139.0.7258.156) we get "variant 2"
  • In Microsoft Edge 142.0.3595.53 both rendered correctly
  • In Chrome 142.0.7444.59 both rendered correctly
  • In Firefox 144.0.2 both rendered correctly

[silverwind]

For me, Chrome 142 and Firefox 145 in MacOS render it fine. Can you maybe also check the browser console for any warnings/errors when it renders broken?

[didim99]

Can you maybe also check the browser console for any warnings/errors when it renders broken?

It seems to no any warnings in browser console, just height of image is 0:

When open "View file" page almost same img rendered correctly:

[didim99]

If I manually change style for img element, I can see the actual image lol!

[silverwind]

Hmm we need to check the size calculation. Maybe there is some bug.

Last question: If a certain browser fails to render, does it fail all the time or only sometimes?

[didim99]

If a certain browser fails to render, does it fail all the time or only sometimes?

For given (or similar) SVGs I see the empty line in my Firefos at least for one year or more any time in every PR/commit when that SVGs appears. In the other words: "the broken SVG is always broken, the correct SVG is always correct".