Deleting non-existent branch through API returns 204

[hramrach]

Description

Deleting non-existent branch through API returns 204 rather than 404

Gitea Version

1.26.0+dev-398-g5e5703694d

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

>24da922624c6b66da3a67fb6365e53be429744b4 main
 61e240ffdeb6870f1f1075813e741820f2b2ad22
 136d66b3fc3ecc82002718736644957d8021c5a4
>83caab6960f7e603631166bc9476f6dccca8fff4 testbranch
 e1e3aed128473456b85b68deab00e5ff50f98003
delete testbranch
https://demo.gitea.com/api/v1/repos/hramrach/testrepo/branches/testbranch DELETE 204 No Content

>24da922624c6b66da3a67fb6365e53be429744b4 main
 61e240ffdeb6870f1f1075813e741820f2b2ad22
 136d66b3fc3ecc82002718736644957d8021c5a4
 83caab6960f7e603631166bc9476f6dccca8fff4
 e1e3aed128473456b85b68deab00e5ff50f98003
delete testbranch
https://demo.gitea.com/api/v1/repos/hramrach/testrepo/branches/testbranch DELETE 204 No Content

>24da922624c6b66da3a67fb6365e53be429744b4 main
 61e240ffdeb6870f1f1075813e741820f2b2ad22
 136d66b3fc3ecc82002718736644957d8021c5a4
 83caab6960f7e603631166bc9476f6dccca8fff4
 e1e3aed128473456b85b68deab00e5ff50f98003
delete testbranch
https://demo.gitea.com/api/v1/repos/hramrach/testrepo/branches/testbranch DELETE 204 No Content

>24da922624c6b66da3a67fb6365e53be429744b4 main
 61e240ffdeb6870f1f1075813e741820f2b2ad22
 136d66b3fc3ecc82002718736644957d8021c5a4
 83caab6960f7e603631166bc9476f6dccca8fff4
 e1e3aed128473456b85b68deab00e5ff50f98003

Git Version

No response

Operating System

No response

How are you running Gitea?

demo.gitea.com

Database

None

Similar problem #28725

[lafriks]

While it could return 404, technically it's not incorrect as branch is deleted :)

What GitHub API return when deleting non-existent branch?

[hramrach]

I do not use github API. I can refer to the canonical implementation:

git branch -D foobar
error: branch 'foobar' not found