"Show more files" button sometimes doesn't work when large number of files changed by a diff

[intelmatt]

Gitea Version

1.25.4

What happened?

First of all, this issue is already fixed on main and 1.25 and 1.26 branches. I'm opening it here only for tracking of the existing issue in 1.25.4.

In v1.25.4, the "Show more files" button shown when a diff has more files than MaxGitDiffFiles loads additional file boxes via fetch and inserts them with replaceWith. The handler loadMoreFiles() does not call window.htmx.process() on the new content, so htmx never wires click handlers to the code-expander-buttons inside the newly-loaded files. The sibling handler for a.diff-load-button (per-file "load diff" button) does call window.htmx.process(el) after replacement; loadMoreFiles() was missed.

How are you running Gitea?

No response

[silverwind]

From what I see 4f1408cdcf fixed this and it is contained in the 1.25.5 release, so you should upgrade to that.