-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Images in Wiki repo not showing in Gitea Wiki #4690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can confirm this is also broken in Gogs |
* Fix serving of raw wiki files other than .md Closes #4690. Closes #4395. Signed-off-by: Gabriel Silva Simões <[email protected]> * Simplify code at routers/repo/wiki.go Signed-off-by: Gabriel Silva Simões <[email protected]> * Add more files to user2/repo1.wiki for testing Signed-off-by: Gabriel Silva Simões <[email protected]> * Update macaron to v1.3.2 Signed-off-by: Gabriel Silva Simões <[email protected]> * Add tests for WikiRaw Signed-off-by: Gabriel Silva Simões <[email protected]> * Fix NewResponseWriter usage due to macaron update Signed-off-by: Gabriel Silva Simões <[email protected]> * Add raw to reserved wiki names Signed-off-by: Gabriel Silva Simões <[email protected]>
as of version 1.8.1 that bug seem to be not fixed. I have uploaded images to raw/image.png to a *.wiki.git repository and it is still 404 |
Seems to be working for provided example in issue description |
I am having trouble verifying the fix too... Any help is appreciated. |
1 similar comment
I am having trouble verifying the fix too... Any help is appreciated. |
@ancoroc The wiki git repo is not the same code git repo. If you want to reference an image on code repo, you have to give it an external link. |
Ok, thanks for the explanation. So no possibility at this time to compose the wiki with pages, subpages and images in subfolders? |
@ancoroc You could push image on wiki git repo in fact and reference it with relative path. |
@lunny You mean like I tried in https://try.gitea.io/298374289734/WikiTest/wiki/Home ? Didn't work for me either. Relative paths and absolute URLs didn't do the trick. |
This works in Gitea version 1.10.2:
|
@bigassforce This only works if the image is in a public repository. If not a dialog box will pop up asking for a log in. |
[x]
):Description
Not much to describe. Image is in main repository to view. Image in wiki repository main folder, image subfolder, images subfolder, raw subfolder. None of the images are displayed in the wiki.
Screenshots
Not neccessary, view page on https://try.gitea.io/bkahlerventer/wiki_test/wiki/Home
The text was updated successfully, but these errors were encountered: