"call of nil" exception when comparing images #8226

Activity

1. lunny

   added

   type/bug

   on Sep 18, 2019
2. lunny

   added this to the 1.10.0 milestone on Sep 18, 2019
3. egrekov commented on Sep 25, 2019

   

   egrekov

   on Sep 25, 2019

   More actions

   Today I caught a similar error when opening a commit.
   template: repo/diff/image_diff:14:29: executing "repo/diff/image_diff" at <call .root.FileExistsInBaseCommit .file.OldName>: error calling call: call of nil

   © Gitea Version: 1.10.0+dev-326-gc05b89a5a
4. guillep2k commented on Sep 26, 2019

   

   guillep2k

   on Sep 26, 2019

   Last edited by guillep2k

   Member

   More actions

   @saitho The easiest way to reproduce this problem is to check a commit that adds an image. The problem is that the commit URL is: /{user}/{repo}/commit/{commit-sha}, and this routes into:

   gitea/routers/repo/commit.go

   Line 193 in f8882f4

   func Diff(ctx *context.Context) {

   Diff() does not set FileExistsInBaseCommit (or other image information), nor calls PrepareCompareDiff(), thus the error.

   I've noticed that you've authored #6784 . Is it possible for you to create a new PR fixing this problem?

   Perhaps a temporary workaround is to change:

   gitea/templates/repo/diff/box.tmpl

   Lines 113 to 115 in f8882f4

   	{{if $isImage}}
   	{{template "repo/diff/image_diff" dict "file" . "root" $}}
   	{{else}}

   Into something like:

   {{if and $isImage ($root.FileExistsInBaseCommit != nil)}}
   	{{template "repo/diff/image_diff" dict "file" . "root" $}}
   {{else}}
   

   Or something around those lines (I'm not quite familiar with macaron syntax).
5. saitho commented on Sep 26, 2019

   

   saitho

   on Sep 26, 2019

   ContributorAuthor

   More actions

   Thanks for your analysis. I added the missing lines (probably lost while rebasing branches) and did some minor adjustments to the image compare functionality. :D
6. techknowlogick

   closed this as completedin #8289on Oct 4, 2019
7. go-gitea

   locked and limited conversation to collaborators on Nov 24, 2020