Skip to content

Documentation for enabling Asciidoctor as an external editor leaves artifacts in body #8676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 7 tasks
chrissexton opened this issue Oct 24, 2019 · 0 comments
Closed
2 of 7 tasks

Documentation for enabling Asciidoctor as an external editor leaves artifacts in body #8676

chrissexton opened this issue Oct 24, 2019 · 0 comments

Comments

@chrissexton
Copy link
Contributor

  • Gitea version (or commit ref):1.11.0+dev-87-g3c63c3ace built with GNU Make 4.2.1, go1.13.3 : bindata, sqlite, sqlite_unlock_notify
  • Git version:2.22.0
  • Operating system:alpine/docker
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

The suggestion for rendering Asciidoctor via external renderers leaves the footer and the close of the <html lang="en"> tag in the output since it does not use embedded mode.

Asciidoctor should probably be put into embedded mode with -e and told to have a level offset of -1 with -a leveloffset=-1. This appears to work well under my setup.

Screenshots

Before:
Screen Shot 2019-10-24 at 13 53 15

After:
Screen Shot 2019-10-24 at 13 54 20
@chrissexton chrissexton mentioned this issue Oct 24, 2019
Merged
zeripath pushed a commit that referenced this issue Oct 25, 2019
@chrissexton @zeripath
Change external asciidoctor tool to embeded mode (#8677)
560a511 
Ref #8676

* add the `-e` flag for embedded mode
* add a level offset to include the title of the document
@anthonyvdotbe anthonyvdotbe mentioned this issue Jan 8, 2020
Closed
7 tasks
@pre-martin pre-martin mentioned this issue Sep 2, 2020
Merged
techknowlogick pushed a commit that referenced this issue Sep 2, 2020
@pre-martin
Fixes cli error for Asciidoctor (#12677)
a0c4c1c 
The original fix for #8676 introduced illegal arguments for Asciidoctor, causing no rendering at all. This PR fixes the command line arguments so that Asciidoctor properly renders the text. See https://asciidoctor.org/docs/user-manual/#piping-content-through-the-cli as reference.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrissexton