Ensure that feeds are appropriately restricted

[zeripath]

Fix #9981

[codecov-io]

Codecov Report

Merging #10018 into master will decrease coverage by <.01%.
The diff coverage is 53.57%.

@@            Coverage Diff             @@
##           master   #10018      +/-   ##
==========================================
- Coverage   42.27%   42.26%   -0.01%     
==========================================
  Files         611      611              
  Lines       80389    80405      +16     
==========================================
- Hits        33988    33987       -1     
- Misses      42225    42239      +14     
- Partials     4176     4179       +3

Impacted Files	Coverage Δ
services/pull/pull.go	33.93% <53.57%> (-0.14%)	⬇️
modules/queue/workerpool.go	41.2% <0%> (-2.58%)	⬇️
modules/log/file.go	75.52% <0%> (-2.1%)	⬇️
modules/git/repo.go	45.87% <0%> (+1.37%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a33a74...0c03606. Read the comment docs.

[guillep2k]

Isn't it strange that user ==nil enables VisibleTypeLimited orgs three lines below?

I was under the impression that user == nil (or user.ID <= 0) meant anonymous/unidentified.

[zeripath]

It's not enabling it - rather restricting them away further. But I should probably add the user ID <= 0 test to that too - DONE

[guillep2k]

Not your fault, the code is previous to your PR. I've just noticed it:

cond = cond.Or(builder.And(
			builder.Eq{"`repository`.is_private": false},
			builder.Or(
				//   A. Aren't in organisations  __OR__
				builder.NotIn("`repository`.owner_id", builder.Select("id").From("`user`").Where(builder.Eq{"type": UserTypeOrganization})),
				//   B. Isn't a private organisation. Limited is OK as long as we're logged in.
				builder.NotIn("`repository`.owner_id", builder.Select("id").From("`user`").Where(builder.In("visibility", orgVisibilityLimit))))))

If I read this right, it's: user can see it if "repository is not private or (rest of the condition)". A limited org has public repos that anonymous users should not be able to see. This condition will make those repos pass, since they've got is_private == false.

I'm pretty tired, so I might be I'm getting this wrong.

[guillep2k]

On a second look... see my comment about orgs.

[guillep2k]

Please disregards my comments about the permissions. They were just fine. 😔