Skip to content

[UI] Show pull icon on pull#10061

Merged
zeripath merged 2 commits into
go-gitea:masterfrom
6543-forks:show-pull-icon-on-pull
Jan 29, 2020
Merged

[UI] Show pull icon on pull#10061
zeripath merged 2 commits into
go-gitea:masterfrom
6543-forks:show-pull-icon-on-pull

Conversation

@6543
Copy link
Copy Markdown
Member

@6543 6543 commented Jan 29, 2020

Before

Bildschirmfoto zu 2020-01-29 18-49-28

After

Bildschirmfoto zu 2020-01-29 18-49-08

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@e2c505f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10061   +/-   ##
=========================================
  Coverage          ?   42.35%           
=========================================
  Files             ?      618           
  Lines             ?    80774           
  Branches          ?        0           
=========================================
  Hits              ?    34213           
  Misses            ?    42352           
  Partials          ?     4209

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2c505f...60bb1b3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 29, 2020
guillep2k
guillep2k reviewed Jan 29, 2020
View reviewed changes
Comment thread modules/graceful/manager_windows.go
guillep2k
guillep2k approved these changes Jan 29, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore my comment about the unrelated change. make fmt must have done that (as for why it was accepted without it before, it beats me).

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 29, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 29, 2020
@zeripath zeripath merged commit 169bb55 into go-gitea:master Jan 29, 2020
@6543 6543 deleted the show-pull-icon-on-pull branch January 29, 2020 18:54
@6543
Copy link
Copy Markdown
Member Author

6543 commented Jan 29, 2020

should I send a backport (only templates/repo/issue/view_title.tmpl change) to 1.11.x branch?

@zeripath zeripath added this to the 1.12.0 milestone Jan 29, 2020
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Jan 29, 2020
@zeripath
Copy link
Copy Markdown
Contributor

zeripath commented Jan 29, 2020

was it previously a pull icon and then it changed or is this a new feature?

@zeripath
Copy link
Copy Markdown
Contributor

zeripath commented Jan 29, 2020

if it's a new feature probably we shouldn't backport

@6543
Copy link
Copy Markdown
Member Author

6543 commented Jan 29, 2020 •
edited
Loading

I would considder this as ui-fix in my opinion

@zeripath
Copy link
Copy Markdown
Contributor

zeripath commented Jan 29, 2020

send a backport then

6543 added a commit to 6543-forks/gitea that referenced this pull request Jan 29, 2020
@6543
[UI] Show pull icon on pull (go-gitea#10061)
c257a7a
@6543 6543 mentioned this pull request Jan 29, 2020
Merged
zeripath pushed a commit that referenced this pull request Jan 29, 2020
@6543
[UI] Show pull icon on pull (#10061) (#10062)
b3549bb
@zeripath zeripath added the backport/done All backports for this PR have been created label Feb 15, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@guillep2k guillep2k guillep2k approved these changes

@jolheiser jolheiser jolheiser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

6 participants

@6543 @codecov-io @zeripath @guillep2k @jolheiser @GiteaBot