Skip to content

Fix code-expansion arc-green theme bug#10180

Merged
sapk merged 4 commits into
go-gitea:masterfrom
6543-forks:fix-dark-css
Feb 7, 2020
Merged

Fix code-expansion arc-green theme bug#10180
sapk merged 4 commits into
go-gitea:masterfrom
6543-forks:fix-dark-css

Conversation

@6543
Copy link
Copy Markdown
Member

@6543 6543 commented Feb 7, 2020 •
edited
Loading

close #10179

new look:
Bildschirmfoto zu 2020-02-07 19-16-06

jolheiser
jolheiser suggested changes Feb 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the very least I think we should avoid !important if we can, but after that I will approve regardless of other suggestion.

Comment thread web_src/less/themes/theme-arc-green.less Outdated
Comment thread web_src/less/themes/theme-arc-green.less Outdated
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 7, 2020
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Feb 7, 2020

Would suggest background-color: rgba(0,0,0,0.1) instead of defining a new RGB color just for this. Also, the color difference seems really low on your screenshot, I would go with something between 0.1 and 0.2.

@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 7, 2020

@silverwind your solution doesn't work ...

jolheiser
jolheiser reviewed Feb 7, 2020
View reviewed changes
Comment thread web_src/less/themes/theme-arc-green.less Outdated
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Feb 7, 2020

It work does for me:

td.blob-excerpt {
    background-color: rgba(0,0,0,.2);
}

@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 7, 2020

just noticed it need td if we like to remove important ...

@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 7, 2020

@silverwind I'll test your solutin with td again ...

@silverwind
Copy link
Copy Markdown
Member

silverwind commented Feb 7, 2020

Yes, match the selector exactly from the base style.

@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 7, 2020

ok works - changed
PS: I used 0.1 because 0.2 was to intensive ... in my option ...

@silverwind
Copy link
Copy Markdown
Member

silverwind commented Feb 7, 2020

0.1 seems to light to me. Maybe meet in the middle at 0.15?

@jolheiser
Copy link
Copy Markdown
Member

jolheiser commented Feb 7, 2020

And when it's settled, a new screenshot please. 🙂

@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 7, 2020

@jolheiser pull desc updated

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@11995bf). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10180   +/-   ##
=========================================
  Coverage          ?   43.42%           
=========================================
  Files             ?      576           
  Lines             ?    79642           
  Branches          ?        0           
=========================================
  Hits              ?    34582           
  Misses            ?    40784           
  Partials          ?     4276

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11995bf...83d94d1. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 7, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 7, 2020
@sapk sapk added type/bug topic/ui Change the appearance of the Gitea UI labels Feb 7, 2020
@sapk sapk added this to the 1.12.0 milestone Feb 7, 2020
@sapk sapk merged commit 11789ae into go-gitea:master Feb 7, 2020
@6543 6543 deleted the fix-dark-css branch February 7, 2020 20:27
6543 added a commit to 6543-forks/gitea that referenced this pull request Feb 7, 2020
@6543
Fix code-expansion arc-green theme bug (go-gitea#10180)
36b6a93 
* fix code-expansion theme bug

* working solution without important

* no new color

* the midle
@6543 6543 mentioned this pull request Feb 7, 2020
Merged
@sapk sapk added backport/done All backports for this PR have been created backport/v1.11 labels Feb 7, 2020
sapk pushed a commit that referenced this pull request Feb 7, 2020
@6543
Fix code-expansion arc-green theme bug (#10180) (#10185)
b16c555 
* fix code-expansion theme bug

* working solution without important

* no new color

* the midle
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@silverwind silverwind silverwind approved these changes

+3 more reviewers

@sapk sapk sapk approved these changes

@guillep2k guillep2k guillep2k approved these changes

@jolheiser jolheiser jolheiser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

[Theme] [Bug] arc-green

7 participants

@6543 @silverwind @jolheiser @codecov-io @sapk @guillep2k @GiteaBot