Skip to content

Restore graceful restart on SIGHUP #10224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2020

Conversation

zeripath
Copy link
Contributor

There was a mistaken change in #10001 which broke graceful restart on SIGHUP.

This PR restores this.

@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 10, 2020
@zeripath zeripath added this to the 1.12.0 milestone Feb 10, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 10, 2020
@zeripath zeripath force-pushed the restore-graceful-restart-sighup branch from bfdc4d2 to b192b63 Compare February 10, 2020 22:25
@codecov-io
Copy link

Codecov Report

Merging #10224 into master will decrease coverage by <.01%.
The diff coverage is 54.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10224      +/-   ##
==========================================
- Coverage   43.64%   43.64%   -0.01%     
==========================================
  Files         576      576              
  Lines       79716    79787      +71     
==========================================
+ Hits        34791    34820      +29     
- Misses      40627    40664      +37     
- Partials     4298     4303       +5
Impacted Files Coverage Δ
models/pull.go 41.36% <0%> (-0.47%) ⬇️
modules/graceful/manager_unix.go 40.83% <0%> (ø) ⬆️
routers/repo/issue.go 37.61% <10%> (-0.4%) ⬇️
routers/user/home.go 56.2% <80%> (+0.87%) ⬆️
models/issue_list.go 68.2% <88%> (+1.27%) ⬆️
services/pull/temp_repo.go 29.05% <0%> (-2.57%) ⬇️
services/pull/patch.go 60.37% <0%> (-2.52%) ⬇️
services/pull/check.go 32.92% <0%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5418a6...b192b63. Read the comment docs.

Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better than before. 👀

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 10, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 10, 2020
@lunny
Copy link
Member

lunny commented Feb 11, 2020

make L-G-T-M work

@lunny lunny merged commit 37892be into go-gitea:master Feb 11, 2020
@zeripath zeripath deleted the restore-graceful-restart-sighup branch February 11, 2020 16:38
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants