Skip to content

Don't manually replace whitespace during render #10291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lafriks merged 7 commits into from
Feb 17, 2020
Merged

Don't manually replace whitespace during render #10291

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
55cd4a6
Don't manually replace whitespace during render
mrsdizzie Feb 16, 2020
8bf4959
Escape elems as well
mrsdizzie Feb 16, 2020
331a129
Revert "Escape elems as well"
mrsdizzie Feb 16, 2020
47ea1a6
restart ci
mrsdizzie Feb 16, 2020
ae1cb8c
remove changes to URLJoin
mrsdizzie Feb 16, 2020
80e8cba
restart ci
mrsdizzie Feb 17, 2020
b502a8e
Merge branch 'master' into fix-10156
techknowlogick Feb 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion modules/markup/markdown/goldmark.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ func (g *GiteaASTTransformer) Transform(node *ast.Document, reader text.Reader,

lnk := string(link)
lnk = giteautil.URLJoin(prefix, lnk)
lnk = strings.Replace(lnk, " ", "+", -1)
link = []byte(lnk)
}
v.Destination = link
Expand Down
1 change: 0 additions & 1 deletion modules/markup/markup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ func RenderWiki(filename string, rawBytes []byte, urlPrefix string, metas map[st
}

func render(parser Parser, rawBytes []byte, urlPrefix string, metas map[string]string, isWiki bool) []byte {
urlPrefix = strings.Replace(urlPrefix, " ", "+", -1)
result := parser.Render(rawBytes, urlPrefix, metas, isWiki)
// TODO: one day the error should be returned.
result, err := PostProcess(result, urlPrefix, metas, isWiki)
Expand Down