fix: set explicit POSTGRES_PASSWORD for pgsql on drone CI #10302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapk
added
type/miscellaneous
backport/v1.10
skip-changelog
This was referenced Feb 16, 2020
|
https://drone.gitea.io/go-gitea/gitea/21332/3/2 Other problems came up 🙁 |
GiteaBot
added
the
lgtm/need 2
|
@sapk I think if you update this the tests should pass |
|
@guillep2k that an other bug that come from time to time. I think there is already an issue. |
guillep2k
approved these changes
Feb 16, 2020
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Feb 16, 2020
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since docker-library/postgres#658 POSTGRES_PASSWORD need to be explicitly set.
Currently this only impact build of #10294 but it should be the same on master when arm64 pull the new image.