Prevent panic on merge to PR#10403
Merged
Merged
Conversation
lunny
approved these changes
Feb 21, 2020
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #10403 +/- ##
==========================================
+ Coverage 43.74% 43.81% +0.06%
==========================================
Files 586 586
Lines 81113 81121 +8
==========================================
+ Hits 35481 35540 +59
+ Misses 41243 41188 -55
- Partials 4389 4393 +4
Continue to review full report at Codecov.
|
guillep2k
approved these changes
Feb 21, 2020
GiteaBot
added
lgtm/done
guillep2k
pushed a commit
to guillep2k/gitea
that referenced
this pull request
Feb 21, 2020
If you attempt to merge to a branch which on a PR there will be a nil pointer error in the pull request checker. This panic is uncaught and will bring down the gitea server. This PR adds protection to prevent this.
zeripath
added a commit
that referenced
this pull request
Feb 21, 2020
If you attempt to merge to a branch which on a PR there will be a nil pointer error in the pull request checker. This panic is uncaught and will bring down the gitea server. This PR adds protection to prevent this. Co-authored-by: zeripath <art27@cantab.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you attempt to merge to a branch which on a PR there will be a nil pointer error in the pull request checker.
This panic is uncaught and will bring down the gitea server.
This PR adds protection to prevent this.