Skip to content

[bugfix] on issue-label-change via API trigger webhooks too#10421

Merged
zeripath merged 11 commits into
go-gitea:masterfrom
6543-forks:fix_9403
Feb 23, 2020
Merged

[bugfix] on issue-label-change via API trigger webhooks too#10421
zeripath merged 11 commits into
go-gitea:masterfrom
6543-forks:fix_9403

Conversation

@6543
Copy link
Copy Markdown
Member

@6543 6543 commented Feb 23, 2020

close #9403

@techknowlogick techknowlogick added this to the 1.12.0 milestone Feb 23, 2020
guillep2k
guillep2k reviewed Feb 23, 2020
View reviewed changes
Comment thread services/issue/label.go Outdated
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 23, 2020
@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 23, 2020 •
edited
Loading

@techknowlogick think this is an bug witch is already in 1.11.x so we need a backport :O

@6543 6543 requested a review from guillep2k February 23, 2020 02:53
@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 23, 2020

ready to review

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 23, 2020
@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 23, 2020

what is wrong with this CI ...

@lafriks
Copy link
Copy Markdown
Member

lafriks commented Feb 23, 2020

Complains about duplicate code:
routers/api/v1/repo/issue_label.go:70: 70-142 lines are duplicate of routers/api/v1/repo/issue_label.go:216-288 (dupl)

@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 23, 2020

now It's a refactor too ;)

@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 23, 2020

wake up lgtm

guillep2k
guillep2k suggested changes Feb 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this check

Comment thread routers/api/v1/repo/issue_label.go
@zeripath zeripath changed the title [bugfix] on issue-lable-change via API trigger webhooks too [bugfix] on issue-label-change via API trigger webhooks too Feb 23, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 23, 2020

Codecov Report

Merging #10421 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10421      +/-   ##
==========================================
+ Coverage   43.66%   43.71%   +0.05%     
==========================================
  Files         586      586              
  Lines       81389    81389              
==========================================
+ Hits        35538    35580      +42     
+ Misses      41457    41410      -47     
- Partials     4394     4399       +5
Impacted Files Coverage Δ
modules/process/manager.go 74.69% <0%> (-3.62%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0%> (-1.93%) ⬇️
models/pull.go 42.37% <0%> (+0.55%) ⬆️
models/notification.go 65.18% <0%> (+1.05%) ⬆️
services/pull/pull.go 36.07% <0%> (+1.17%) ⬆️
services/pull/temp_repo.go 34.18% <0%> (+2.56%) ⬆️
services/pull/patch.go 66.03% <0%> (+3.14%) ⬆️
services/pull/check.go 55.48% <0%> (+17.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce262a...a22bf3c. Read the comment docs.

@x-beaudet
Copy link
Copy Markdown

x-beaudet commented Feb 23, 2020

smells good ! thanx ! :-)

@zeripath zeripath merged commit 39b507e into go-gitea:master Feb 23, 2020
@6543 6543 deleted the fix_9403 branch February 23, 2020 23:41
@lunny
Copy link
Copy Markdown
Member

lunny commented Feb 24, 2020

Please send backport.

@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 24, 2020

I will tomorow, if someone like to send a backport, feel free to

6543 added a commit to 6543-forks/gitea that referenced this pull request Feb 24, 2020
@6543
Trigger webhooks on issue label-change via API too (go-gitea#10421)
0967800 
* trigger webhooks with api too

* fix comment

* notify report old too

* CI restart

* restart CI again

* remove duplicated code
@6543 6543 mentioned this pull request Feb 24, 2020
Merged
@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 24, 2020

done -> #10439

@guillep2k guillep2k added the backport/done All backports for this PR have been created label Feb 24, 2020
zeripath pushed a commit that referenced this pull request Feb 24, 2020
@6543
Trigger webhooks on issue label-change via API too (#10421) (#10439)
9e6ad64 
* trigger webhooks with api too

* fix comment

* notify report old too

* CI restart

* restart CI again

* remove duplicated code
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

Webhook not activated when setting a label on an issue

10 participants

@6543 @lafriks @codecov-io @x-beaudet @lunny @guillep2k @techknowlogick @zeripath @GiteaBot @jolheiser