Show the username as a fallback on feeds if full name is blank

[jamesorlakin]

While the DEFAULT_SHOW_FULL_NAME works well, there's a bug on the feed/dashboard page that causes the username not be used as a fallback and nothing shown instead:

This PR copies the logic from DisplayName in models/user.go:741 to return the username as a fallback for the template:

(where review is the username, and Jimbo as a user with the full name set)

I'm happy to make a backport too. 😃

[zeripath]

Not that we're the most efficient system but perhaps it would be better to restructure this so we only do the trimspace if the setting is set.

[jamesorlakin]

To be honest I'm not really sure what the trim is there for. I guess if the user puts in a full name of just spaces we should ignore it, but surely that validation should be done at setting time?

[codecov-io]

Codecov Report

Merging #10438 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #10438      +/-   ##
==========================================
- Coverage   43.69%   43.68%   -0.02%     
==========================================
  Files         586      586              
  Lines       81411    81411              
==========================================
- Hits        35574    35564      -10     
- Misses      41430    41437       +7     
- Partials     4407     4410       +3

Impacted Files	Coverage Δ
routers/api/v1/repo/pull.go	34.63% <ø> (ø)	⬆️
routers/routes/routes.go	86.27% <100%> (ø)	⬆️
modules/indexer/stats/queue.go	62.5% <0%> (-18.75%)	⬇️
modules/indexer/stats/db.go	40.62% <0%> (-18.75%)	⬇️
modules/git/utils.go	65.67% <0%> (-4.48%)	⬇️
modules/queue/workerpool.go	56.93% <0%> (-1.07%)	⬇️
modules/git/repo.go	46.78% <0%> (-0.92%)	⬇️
models/notification.go	64.4% <0%> (+0.84%)	⬆️
modules/indexer/issues/indexer.go	58.9% <0%> (+1.36%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89639aa...c517044. Read the comment docs.

[jamesorlakin]

@zeripath String trimming in both the user and action models are now done only if DEFAULT_SHOW_FULL_NAME is configured.

[lafriks]

Suggested change

	return a.GetActFullName()
	return trimmedFullName

[jamesorlakin]

Doh! 🤦‍♂