Update markbates/goth#10444
Merged
Merged
Conversation
- Fixes a JWT decoding issue in the OpenID provider - Updates the GitHub provider to use the authorization header for authentication - Updates the Twitch provider for Twitch's v5 API changes - Adds the email and is_private_email fields to the Apple provider's GetUser implementation - Modifies gothic to export a non-collidable context key for setting the Provider in a context.Context - Adds new scopes to the Spotify provider - Adds the IDToken from OpenID providers on the user struct - Make Apple provider's SecretParams public - Adds support for sign in with Apple, and drops support for Go versions 1.7 and 1.8 - Fixes the Slack provider's FetchURL logic to use the appropriate scope for the info it needs Signed-off-by: Oscar LÃfwenhamn <oscar.lofwenhamn@cgi.com>
Member
|
Note: I've applied |
GiteaBot
added
the
lgtm/need 2
techknowlogick
approved these changes
Feb 24, 2020
GiteaBot
added
lgtm/need 1
Contributor
Author
|
Super, and thanks for the quick review. |
6543
approved these changes
Feb 24, 2020
GiteaBot
added
lgtm/done
Contributor
Author
|
Test successful and ready for merging. |
Member
|
@oscarlofwenhamn thanks much :) could you also backport these changes to the release/v1.11 branch? |
Contributor
Author
|
I'd be happy to! Does that mean I make another PR with release/v1.11 as the target, or rather I checkout the release/v1.11 branch; patch and then make a new PR? I'm guessing the latter, but always best to check. |
Member
|
That's correct, it'd be the latter. If you have any other questions please don't hesitate to ask :) |
Contributor
Author
|
Great, I'll get on it immediately. Cheers! And again, thanks for the fast responses, nice interacting actively. :) |
techknowlogick
added
the
backport/done
zeripath
added
the
topic/security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update markbates/goth to 1.62.2