go 1.14

[techknowlogick]

Note: This also increases the minimum supported version of go to 1.12

[sapk]

Please update the go.mod version to use latest go std lib.

[silverwind]

This also increases the minimum supported version of go to 1.12

Need to update Makefile, README.md, .drone.yml and docs with 1.11 -> 1.12.

[techknowlogick]

Failing due to error described in #10552 (and a few other places)

[techknowlogick]

Current template that need resolution:

template: repo/issue/list:271:46: executing "repo/issue/list" at <(len .PullRequest.ConflictedFiles) gt 0>: can't give argument to non-function len .PullRequest.ConflictedFiles

[techknowlogick]

Ok, now that template issues have been resolved, it seems that on ARM there are failures when TestAPIUpdateFile is run. I suspect it is related to indexing of code.

[6543]

#10597 got merged can you update/use goversion var ;

[jolheiser]

Resolved conflicts. 👍

[lafriks]

looks like some kind of deadlock in queues on arm

[sapk]

Removing my blocking review since this part has been fixed.

Removing my blocking review since this part has been fixed.

[guillep2k]

https://golang.org/doc/go1.14

A consequence of the implementation of preemption is that on Unix systems, including Linux and macOS systems, programs built with Go 1.14 will receive more signals than programs built with earlier releases. This means that programs that use packages like syscall or golang.org/x/sys/unix will see more slow system calls fail with EINTR errors. Those programs will have to handle those errors in some way, most likely looping to try the system call again. For more information about this see man 7 signal for Linux systems or similar documentation for other systems.

Should we be concerned about this? How many of our vendored packages use system calls?

[silverwind]

@guillep2k

$ grep '"syscall"' vendor -r | wc -l
161
$ grep '"golang.org/x/sys/unix"' vendor -r | wc -l
11

[techknowlogick]

ping LG-TM