Skip to content

Backport: Handle push rejection message in Merge & Web Editor (#10373)#10495

Closed
guillep2k wants to merge 1 commit into
go-gitea:release/v1.11from
guillep2k:backport-10373
Closed

Backport: Handle push rejection message in Merge & Web Editor (#10373)#10495
guillep2k wants to merge 1 commit into
go-gitea:release/v1.11from
guillep2k:backport-10373

Conversation

@guillep2k
Copy link
Copy Markdown
Member

@guillep2k guillep2k commented Feb 27, 2020

Backport #10373

* Handle push rejection message in Merge

* placate golangci-lint

* Fix sanitize, adjust message handling

* oops

* Oops

* Handle push-rejection in webeditor CRUD too

* Apply suggestions from code review

* Fixed conflicts in: modules/repofiles/temp_repo.go

Co-authored-by: Lauris BH <lauris@nix.lv>
@guillep2k guillep2k added type/bug type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Feb 27, 2020
@guillep2k guillep2k added this to the 1.11.2 milestone Feb 27, 2020
@guillep2k
Copy link
Copy Markdown
Member Author

@zeripath please check my conflict resolution in modules/repofiles/temp_repo.go. Thank you!

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 27, 2020
@zeripath
Copy link
Copy Markdown
Contributor

@guillep2k I've reuploaded as another PR with the necessary fixes.

@zeripath zeripath closed this Feb 27, 2020
@zeripath
Copy link
Copy Markdown
Contributor

See #10497

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/bug type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants