Avoid mailing users that have explicitly unwatched an issue (#10475)#10500
Merged
Conversation
guillep2k
reviewed
Feb 27, 2020
6543
commented
Feb 27, 2020
Avoid mailing explicit unwatched
f4762ad to
6abf5ad
Compare
Member
Author
|
@guillep2k done |
guillep2k
approved these changes
Feb 27, 2020
Member
|
I understand this is a backport so LGTM (just to move things further) but it doesn't seem clean to call that getIssuesWatchers twice, rather I'd expect such a function to internally remove explicit unsubscribers... |
Member
Author
|
@strk it doesnt work that way ... since you can "watch" via repo watch or participants or issuewatch ... and there are 3 types of issuewatch:
So i can query the userIDs in two functioncalls or query all IssueWatch entrys for a issue and itterate throu it fo set / unset ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backports #10475