Remove Unused Functions#10516
Conversation
(you still can resolve user by "k, err := GetPublicKeyByID; userID := k.OwnerID")
|
-------------------------------------- space ---------------------------------------------- |
|
Removing code is the best change. |
|
@sapk via golands "code inspection" and a lot of recusrive grep + time to look throu the code |
|
@6543 Ok, it looks good at first glance. For code part you hesitate we could use the Deprecated: syntax to highlight part that need to be cleaned later. But that already a good batch. Thanks for the time taken. |
Codecov Report
@@ Coverage Diff @@
## master #10516 +/- ##
==========================================
- Coverage 43.86% 43.82% -0.05%
==========================================
Files 584 584
Lines 81649 81649
==========================================
- Hits 35815 35782 -33
- Misses 41399 41430 +31
- Partials 4435 4437 +2
Continue to review full report at Codecov.
|
each commit is one related remove ... so feel free to point to a specific commit hash to revert ...
It is a huge imprvement for the modules/structs package ;) since it should not contain any function ...