Skip to content

Ensure executable bit is kept on the web editor#10607

Merged
sapk merged 2 commits into
go-gitea:masterfrom
zeripath:keep-executable-bit-in-editor
Mar 4, 2020
Merged

Ensure executable bit is kept on the web editor#10607
sapk merged 2 commits into
go-gitea:masterfrom
zeripath:keep-executable-bit-in-editor

Conversation

@zeripath
Copy link
Copy Markdown
Contributor

@zeripath zeripath commented Mar 4, 2020

When editing a file with the editor - if the file had an executable bit keep it set.

Fix #7771

@zeripath zeripath added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Mar 4, 2020
@zeripath zeripath added this to the 1.12.0 milestone Mar 4, 2020
@lafriks lafriks added type/enhancement An improvement of existing functionality type/bug and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/enhancement An improvement of existing functionality labels Mar 4, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2020
@lafriks
Copy link
Copy Markdown
Member

lafriks commented Mar 5, 2020

I think this could be backported

@zeripath zeripath deleted the keep-executable-bit-in-editor branch March 5, 2020 07:06
zeripath pushed a commit to zeripath/gitea that referenced this pull request Mar 5, 2020
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
lunny added a commit that referenced this pull request Mar 5, 2020
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>

Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
@lafriks lafriks added the backport/done All backports for this PR have been created label Mar 5, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File looses executable bit after editing through web interface

5 participants