Skip to content

Convert plumbing.ErrReferenceNotFound to git.ErrNotExist in GetRefCommitID (#10676)#10797

Merged
lafriks merged 2 commits into
go-gitea:release/v1.11from
zeripath:backport-10676
Mar 23, 2020
Merged

Convert plumbing.ErrReferenceNotFound to git.ErrNotExist in GetRefCommitID (#10676)#10797
lafriks merged 2 commits into
go-gitea:release/v1.11from
zeripath:backport-10676

Conversation

@zeripath
Copy link
Copy Markdown
Contributor

@zeripath zeripath commented Mar 22, 2020

Backport #10676

Convert plumbing.ErrReferenceNotFound to git.ErrNotExist in GetRefCommitID

Signed-off-by: Andrew Thornton art27@cantab.net

Backport go-gitea#10676

* Fix panic in API pulls when headbranch does not exist
* refix other reference to plumbing.ErrReferenceNotFound

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.11.4 milestone Mar 22, 2020
@zeripath zeripath changed the title Fix panic in API pulls when headbranch does not exist (#10676) Convert plumbing.ErrReferenceNotFound to git.ErrNotExist in GetRefCommitID (#10676) Mar 22, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 22, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 23, 2020
@zeripath
Copy link
Copy Markdown
Contributor Author

Make lg-tm work

@lafriks
Copy link
Copy Markdown
Member

lafriks commented Mar 23, 2020

Please force push to trigger drone managed to redeliver webhook from settings

Comment thread modules/git/repo_commit.go Outdated
Comment thread modules/git/repo_commit.go Outdated
Co-Authored-By: Lauris BH <lauris@nix.lv>
@lafriks
Copy link
Copy Markdown
Member

lafriks commented Mar 23, 2020

Make lg-tm work

@lafriks lafriks merged commit 3dabfd4 into go-gitea:release/v1.11 Mar 23, 2020
@zeripath zeripath deleted the backport-10676 branch March 23, 2020 13:11
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants