Skip to content

Fix milestones too many SQL variables bug#10880

Merged
lafriks merged 4 commits into
go-gitea:masterfrom
lunny:lunny/fix_milestone_too_many_in
Mar 31, 2020
Merged

Fix milestones too many SQL variables bug#10880
lafriks merged 4 commits into
go-gitea:masterfrom
lunny:lunny/fix_milestone_too_many_in

Conversation

@lunny
Copy link
Copy Markdown
Member

@lunny lunny commented Mar 29, 2020

As title.

@guillep2k
Copy link
Copy Markdown
Member

guillep2k commented Mar 31, 2020

Fixes #9841

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 31, 2020
@guillep2k guillep2k added this to the 1.12.0 milestone Mar 31, 2020
@lunny lunny force-pushed the lunny/fix_milestone_too_many_in branch from 90fb900 to a950a27 Compare March 31, 2020 01:59
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 31, 2020

Codecov Report

Merging #10880 into master will increase coverage by 0.04%.
The diff coverage is 84.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10880      +/-   ##
==========================================
+ Coverage   43.40%   43.45%   +0.04%     
==========================================
  Files         593      593              
  Lines       83343    83353      +10     
==========================================
+ Hits        36175    36220      +45     
+ Misses      42673    42642      -31     
+ Partials     4495     4491       -4
Impacted Files Coverage Δ
models/repo_list.go 77.32% <62.50%> (-0.18%) ⬇️
routers/user/home.go 58.27% <82.45%> (+4.09%) ⬆️
models/issue_milestone.go 69.16% <100.00%> (+1.54%) ⬆️
modules/git/utils.go 65.67% <0.00%> (-4.48%) ⬇️
models/gpg_key.go 53.42% <0.00%> (-0.53%) ⬇️
modules/git/repo.go 48.53% <0.00%> (+0.41%) ⬆️
routers/repo/view.go 36.82% <0.00%> (+0.67%) ⬆️
models/unit.go 44.44% <0.00%> (+2.46%) ⬆️
modules/indexer/stats/db.go 59.37% <0.00%> (+9.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf847b9...e2065b6. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 31, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 31, 2020
@lafriks lafriks merged commit 73cf0e2 into go-gitea:master Mar 31, 2020
@lafriks
Copy link
Copy Markdown
Member

lafriks commented Mar 31, 2020

Please send backport

@lunny lunny deleted the lunny/fix_milestone_too_many_in branch March 31, 2020 08:44
lunny added a commit to lunny/gitea that referenced this pull request Mar 31, 2020
@lunny
Fix milestones too many SQL variables bug (go-gitea#10880)
febbae6 
* Fix milestones too many SQL variables bug

* Fix test

* Don't display repositories with no milestone and fix tests

* Remove unused code and add some comments
@lunny lunny mentioned this pull request Mar 31, 2020
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Mar 31, 2020
jolheiser pushed a commit that referenced this pull request Mar 31, 2020
@lunny
Fix milestones too many SQL variables bug (#10880) (#10904)
139fc7c 
* Fix milestones too many SQL variables bug

* Fix test

* Don't display repositories with no milestone and fix tests

* Remove unused code and add some comments
@guillep2k guillep2k mentioned this pull request Apr 1, 2020
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

6 participants

@lunny @guillep2k @codecov-io @lafriks @mrsdizzie @GiteaBot