Refresh codemirror on show pull comment tab#11100
Merged
Merged
Conversation
Fix go-gitea#10975 Signed-off-by: Andrew Thornton <art27@cantab.net>
Member
|
Does this also apply to new issues? |
GiteaBot
added
the
lgtm/need 2
Contributor
Author
|
I don't think that issues were ever affected, certainly http://localhost/gitea/administrator/merge-test/issues/new?body=rabbits+feet just works on master. |
GiteaBot
added
lgtm/need 1
mrsdizzie
approved these changes
Apr 16, 2020
GiteaBot
added
lgtm/done
Member
|
didnt had time to check but nice 🎉 |
Member
lunny
approved these changes
Apr 17, 2020
Member
|
Ping lg-tm |
Contributor
Author
|
@silverwind it's already initialised with the correct value. The issue appears to be that the field is hidden and then shown. |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 18, 2020
Fix go-gitea#10975 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
guillep2k
added a commit
that referenced
this pull request
Apr 18, 2020
Fix #10975 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Fix go-gitea#10975 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to create a new PR the comment field does not show the default data until the field is clicked. This PR calls
autoSimpleMDE.codemirror.refresh();to cause the default data to be shown.Fix #10975
Signed-off-by: Andrew Thornton art27@cantab.net