Skip to content

On Repo Deletion: Delete related TrackedTimes too#11110

Merged
zeripath merged 4 commits into
go-gitea:masterfrom
6543-forks:fix-repo-deletion-add-related-tracked-times_10280
Apr 18, 2020
Merged

On Repo Deletion: Delete related TrackedTimes too#11110
zeripath merged 4 commits into
go-gitea:masterfrom
6543-forks:fix-repo-deletion-add-related-tracked-times_10280

Conversation

@6543
Copy link
Copy Markdown
Member

@6543 6543 commented Apr 17, 2020

as title
close #10280

@6543
Copy link
Copy Markdown
Member Author

6543 commented Apr 17, 2020

will need a backport

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 17, 2020
@6543 6543 mentioned this pull request Apr 17, 2020
Closed
7 tasks
@6543
Copy link
Copy Markdown
Member Author

6543 commented Apr 18, 2020

@techknowlogick would be nice if you can add this to 1.12 too :)

@techknowlogick techknowlogick added this to the 1.12.0 milestone Apr 18, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 18, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 18, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 18, 2020

Codecov Report

Merging #11110 into master will increase coverage by 0.01%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11110      +/-   ##
==========================================
+ Coverage   43.53%   43.54%   +0.01%     
==========================================
  Files         599      599              
  Lines       84825    84829       +4     
==========================================
+ Hits        36927    36939      +12     
+ Misses      43351    43346       -5     
+ Partials     4547     4544       -3
Impacted Files Coverage Δ
models/repo.go 51.44% <25.00%> (-0.07%) ⬇️
models/unit.go 41.97% <0.00%> (-2.47%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.93%) ⬇️
modules/git/repo.go 49.79% <0.00%> (-1.26%) ⬇️
routers/repo/view.go 36.14% <0.00%> (-0.68%) ⬇️
models/gpg_key.go 53.95% <0.00%> (+0.52%) ⬆️
services/pull/pull.go 34.16% <0.00%> (+0.76%) ⬆️
services/pull/temp_repo.go 35.04% <0.00%> (+0.85%) ⬆️
modules/queue/workerpool.go 59.07% <0.00%> (+1.06%) ⬆️
modules/process/manager.go 78.31% <0.00%> (+3.61%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38d5f88...c07bdf4. Read the comment docs.

@6543
Copy link
Copy Markdown
Member Author

6543 commented Apr 18, 2020

ready to merge 🚀

@zeripath
Copy link
Copy Markdown
Contributor

zeripath commented Apr 18, 2020

Make lg-tm work

@zeripath zeripath merged commit 4be7cf0 into go-gitea:master Apr 18, 2020
@zeripath zeripath changed the title [BugFix] On Repo Deletion: Delete related TrackedTimes too On Repo Deletion: Delete related TrackedTimes too Apr 18, 2020
@zeripath
Copy link
Copy Markdown
Contributor

zeripath commented Apr 18, 2020

Please send backport

@lafriks lafriks deleted the fix-repo-deletion-add-related-tracked-times_10280 branch April 18, 2020 21:41
6543 added a commit to 6543-forks/gitea that referenced this pull request Apr 18, 2020
@6543
On Repo Deletion: Delete related TrackedTimes too (go-gitea#11110)
74b8996
@6543 6543 mentioned this pull request Apr 18, 2020
Merged
@6543
Copy link
Copy Markdown
Member Author

6543 commented Apr 18, 2020

Backport: #11125

@lafriks lafriks added the backport/done All backports for this PR have been created label Apr 18, 2020
lunny pushed a commit that referenced this pull request Apr 19, 2020
@6543
On Repo Deletion: Delete related TrackedTimes too (#11110) (#11125)
245d6eb
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
On Repo Deletion: Delete related TrackedTimes too (go-gitea#11110)
b054ff0
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

Times API breaks after deleting repo containing issues with tracked times

8 participants

@6543 @codecov-io @zeripath @lunny @guillep2k @techknowlogick @lafriks @GiteaBot