Skip to content

Prevent clones and pushes to disabled wiki#11131

Merged
zeripath merged 2 commits into
go-gitea:masterfrom
zeripath:disable-wiki-if-wiki-disabled
Apr 19, 2020
Merged

Prevent clones and pushes to disabled wiki#11131
zeripath merged 2 commits into
go-gitea:masterfrom
zeripath:disable-wiki-if-wiki-disabled

Conversation

@zeripath
Copy link
Copy Markdown
Contributor

If the repository wiki is disabled prevent pushes and clones to the repository wiki

Signed-off-by: Andrew Thornton art27@cantab.net

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.12.0 milestone Apr 19, 2020
Comment thread routers/repo/http.go
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 19, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 19, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2020
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #11131 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11131   +/-   ##
=======================================
  Coverage   43.47%   43.47%           
=======================================
  Files         600      600           
  Lines       85108    85135   +27     
=======================================
+ Hits        37002    37015   +13     
- Misses      43537    43553   +16     
+ Partials     4569     4567    -2     
Impacted Files Coverage Δ
routers/private/serv.go 33.44% <0.00%> (-1.96%) ⬇️
routers/repo/http.go 41.68% <0.00%> (-0.93%) ⬇️
models/gpg_key.go 53.42% <0.00%> (-0.53%) ⬇️
modules/git/repo.go 50.62% <0.00%> (-0.42%) ⬇️
modules/queue/unique_queue_disk_channel.go 55.76% <0.00%> (+1.92%) ⬆️
services/pull/patch.go 69.23% <0.00%> (+3.49%) ⬆️
modules/git/utils.go 70.14% <0.00%> (+4.47%) ⬆️
modules/indexer/stats/db.go 50.00% <0.00%> (+9.37%) ⬆️
modules/indexer/stats/queue.go 81.25% <0.00%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9588d2c...e85db24. Read the comment docs.

@zeripath zeripath merged commit 41f0558 into go-gitea:master Apr 19, 2020
@zeripath zeripath deleted the disable-wiki-if-wiki-disabled branch April 19, 2020 14:27
@lunny
Copy link
Copy Markdown
Member

lunny commented Apr 19, 2020

@zeripath Please send backport to v1.11

@lafriks lafriks added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Apr 19, 2020
zeripath added a commit to zeripath/gitea that referenced this pull request Apr 19, 2020
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit that referenced this pull request Apr 19, 2020
Backport #11131

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the backport/done All backports for this PR have been created label Apr 19, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants