Skip to content

api.Context.NotFound(...) should tolerate nil #11288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lafriks merged 3 commits into from
May 5, 2020
Merged

api.Context.NotFound(...) should tolerate nil #11288

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb46e73
api.Context.NotFound(...) should tolerate nil
zeripath May 4, 2020
d7211f1
Merge branch 'master' into fix-11286-api.Context.NotFound-should-tole…
lafriks May 4, 2020
8f6740a
Merge branch 'master' into fix-11286-api.Context.NotFound-should-tole…
lafriks May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions modules/context/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,11 @@ func (ctx *APIContext) NotFound(objs ...interface{}) {
var message = "Not Found"
var errors []string
for _, obj := range objs {
// Ignore nil
if obj == nil {
continue
}

if err, ok := obj.(error); ok {
errors = append(errors, err.Error())
} else {
Expand Down