Skip to content

When deleting a tracked time through the API return 404 not 500#11319

Merged
zeripath merged 3 commits into
go-gitea:masterfrom
6543-forks:fix-trackedtime_unintended-500
May 7, 2020
Merged

When deleting a tracked time through the API return 404 not 500#11319
zeripath merged 3 commits into
go-gitea:masterfrom
6543-forks:fix-trackedtime_unintended-500

Conversation

@6543
Copy link
Copy Markdown
Member

@6543 6543 commented May 7, 2020

as title

@zeripath zeripath changed the title [Fix] [API] return 404 not 500 if trackedTime not exist When deleting a tracked time through the API return 404 not 500 May 7, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 7, 2020
@zeripath zeripath added this to the 1.12.0 milestone May 7, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 7, 2020
@zeripath
Copy link
Copy Markdown
Contributor

zeripath commented May 7, 2020

make lg-tm work

@zeripath zeripath merged commit 486e4c8 into go-gitea:master May 7, 2020
@zeripath
Copy link
Copy Markdown
Contributor

zeripath commented May 7, 2020

Please send backport 😛

@6543 6543 deleted the fix-trackedtime_unintended-500 branch May 7, 2020 18:13
6543 added a commit to 6543-forks/gitea that referenced this pull request May 7, 2020
@6543
Copy link
Copy Markdown
Member Author

6543 commented May 7, 2020

Backport #11326

@lafriks lafriks added the backport/done All backports for this PR have been created label May 7, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants