fix bug about can't skip commits base on base branch#11555
Merged
Conversation
Signed-off-by: a1012112796 <1012112796@qq.com>
Member
Author
|
Please review, Thanks :) |
GiteaBot
added
the
lgtm/need 2
Member
|
O nice - will check it out 🎉 |
lafriks
reviewed
Jun 8, 2020
Co-authored-by: Lauris BH <lauris@nix.lv>
lafriks
reviewed
Jun 14, 2020
Co-authored-by: Lauris BH <lauris@nix.lv>
Member
|
I'm actualy just thinking how i can reproduce the bug to test your patch 🤔 |
Member
Author
Maybe you can copy go-sdk to your test env with“New Migration”. |
Member
|
finaly had time and could reproduce it - this works perfect :) |
6543
approved these changes
Jun 24, 2020
GiteaBot
added
lgtm/need 1
Member
|
big thanks for fixing this anoying bug 👍 |
mrsdizzie
approved these changes
Jun 24, 2020
GiteaBot
added
lgtm/done
Contributor
|
make lg-tm work |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* fix bug about can't skip commits base on base branch Signed-off-by: a1012112796 <1012112796@qq.com> * Update modules/git/commit.go Co-authored-by: Lauris BH <lauris@nix.lv> * Update models/issue_comment.go Co-authored-by: Lauris BH <lauris@nix.lv> * fix lint Co-authored-by: Lauris BH <lauris@nix.lv>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix bug about can't skip commits base on base branch. I know it's not a good solution, but I have no other way now.
test with demo:
fix #11536