Skip to content

Fix message wrapping on PR commit list #11616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeripath merged 9 commits into from
Jun 3, 2020
Merged

Fix message wrapping on PR commit list #11616

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2c0fb02
Fix message wrapping on PR commit list
CirnoT May 25, 2020
7fa336d
Update templates/repo/commits_list_small.tmpl
CirnoT May 27, 2020
fefa1af
Merge branch 'master' into wrap-pr-commit
lafriks May 27, 2020
4094a71
Merge branch 'master' into wrap-pr-commit
zeripath May 29, 2020
b11b6c4
Merge branch 'master' into wrap-pr-commit
CirnoT Jun 1, 2020
f382960
Merge branch 'master' into wrap-pr-commit
techknowlogick Jun 2, 2020
6a1b73c
Merge branch 'master' into wrap-pr-commit
techknowlogick Jun 2, 2020
7bc96bd
Merge remote-tracking branch 'remotes/upstream/master' into wrap-pr-c…
CirnoT Jun 3, 2020
b898f6f
Merge branch 'master' into wrap-pr-commit
techknowlogick Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions templates/repo/commits_list_small.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,16 @@
{{else}}
<span class="{{$class}}">
{{end}}
<span class="shortsha">{{ShortSha .ID.String}}</span>
<span class="shortsha">{{ShortSha .ID.String}}</span>
{{if $.Issue.PullRequest.BaseRepo.Name}}
</a>
{{else}}
</span>
{{end}}
</span>

<span class="message-wrapper">
{{ $commitLink:= printf "%s/%s/%s/commit/%s" AppSubUrl $.Issue.PullRequest.BaseRepo.OwnerName $.Issue.PullRequest.BaseRepo.Name .ID }}
<span class="mono commit-summary has-emoji{{if gt .ParentCount 1}} grey text{{end}}" title="{{.Summary}}">{{RenderCommitMessageLinkSubject .Message ($.Issue.PullRequest.BaseRepo.Link|Escape) $commitLink $.Issue.PullRequest.BaseRepo.ComposeMetas}}</span>
</span>
{{ $commitLink:= printf "%s/%s/%s/commit/%s" AppSubUrl $.Issue.PullRequest.BaseRepo.OwnerName $.Issue.PullRequest.BaseRepo.Name .ID }}
<span class="mono commit-summary has-emoji{{if gt .ParentCount 1}} grey text{{end}}" title="{{.Summary}}">{{RenderCommitMessageLinkSubject .Message ($.Issue.PullRequest.BaseRepo.Link|Escape) $commitLink $.Issue.PullRequest.BaseRepo.ComposeMetas}}</span>
Comment thread
CirnoT marked this conversation as resolved.
Outdated
{{if IsMultilineCommitMessage .Message}}
<button class="basic compact mini ui icon button commit-button"><i class="ellipsis horizontal icon"></i></button>
{{end}}
Expand Down