Skip to content

Fix missing authorization check on pull for public repos of private/limited org #11656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeripath merged 11 commits into from
May 29, 2020
Merged

Fix missing authorization check on pull for public repos of private/limited org #11656

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
43fab72
Fix missing authorization check on pull for public repos of private/l…
CirnoT May 28, 2020
2f71214
fix import sort
CirnoT May 28, 2020
8301094
Merge branch 'master' into private-repo-pull
lafriks May 28, 2020
18e0ba6
Rework for push-to-create
CirnoT May 28, 2020
c954088
simpler
CirnoT May 28, 2020
f0ea3df
Merge branch 'master' into private-repo-pull
zeripath May 28, 2020
4c3a08b
Merge branch 'master' into private-repo-pull
guillep2k May 29, 2020
fe838ef
Merge branch 'master' into private-repo-pull
guillep2k May 29, 2020
928f78d
Merge branch 'master' into private-repo-pull
lafriks May 29, 2020
a07d4e1
Merge branch 'master' into private-repo-pull
lafriks May 29, 2020
38684f0
Merge branch 'master' into private-repo-pull
zeripath May 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion routers/repo/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import (
"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/process"
"code.gitea.io/gitea/modules/setting"
"code.gitea.io/gitea/modules/structs"
"code.gitea.io/gitea/modules/timeutil"
repo_service "code.gitea.io/gitea/services/repository"
)
Expand Down Expand Up @@ -125,8 +126,13 @@ func HTTP(ctx *context.Context) {
return
}

if err := repo.GetOwner(); err != nil {
ctx.ServerError("GetOwner", err)
return
}

// Only public pull don't need auth.
isPublicPull := repoExist && !repo.IsPrivate && isPull
isPublicPull := repoExist && !repo.IsPrivate && repo.Owner.Visibility == structs.VisibleTypePublic && isPull
var (
askAuth = !isPublicPull || setting.Service.RequireSignInView
authUser *models.User
Expand Down