Replace jquery-datetimepicker with native date input#11684
Conversation
|
Something very weird is going on, when I select any date, the date set is always +1 day from what I selected. |
|
Works fine on GitHub; the issue isn't with native date picker, the date selected and sent to server is fine, but date saved in database is always +1 day. |
|
Weird. I see |
|
Chromium sends |
|
In database it is set to |
|
Is this a Chromium bug? I thought |
|
MDN says:
|
|
I'm testing it on issue due date, assuming it should behave the same way. |
|
Due date also sends with time info for me so there is a bug there that is not present on milestone. |
|
Indeed, works fine on milestone. Wonder why due date sends time. |
|
It's wrongly passing the date to the JS |
|
I tried changing it to send |
|
Any more reviews? This is ready from my side. |
|
Need to resolve conflicts @silverwind |
This removes the jQuery plugin as well as the associated config options. Native input[type=date] does not require a language attribute as it is localized by default, except for the placeholder attribute for which I currently piggy-back the repo.issues.due_date_form localization option. Implementation should pretty much match GH. Of note is that Safari does not provide a UI for this input type, but I don't think providing one is neccessary and GH did not bother either.
|
Yeah, just noticed that, rebased. |
This removes the jQuery plugin as well as the associated config options. Native input[type=date] does not require a language attribute as it is localized by default, except for the placeholder attribute for which I currently piggy-back the repo.issues.due_date_form localization option. Implementation should pretty much match GH. Of note is that Safari does not provide a UI for this input type, but I don't think providing one is neccessary and GH did not bother either. Co-authored-by: techknowlogick <techknowlogick@gitea.io>


This removes the jQuery plugin as well as the associated config options. Native input[type=date] does not require a language attribute as it is localized by default, except for the placeholder attribute for which I currently piggy-back the repo.issues.due_date_form localization option.
Implementation should pretty much match GH. Of note is that Safari does not provide a UI for this input type, but I don't think providing one is neccessary and GH did not bother either.
Before:

After:
