[API] Expose allowed Reactions#11735
Merged
Merged
Conversation
mrsdizzie
suggested changes
Jun 2, 2020
GiteaBot
added
the
lgtm/need 2
Member
|
Could add a small test to see it works too? |
Member
Author
|
@mrsdizzie sorry was in a rush when I wrote that code |
Member
Author
|
PS: added the code to integration test since adding it to the normal Tests result in a wrong test result |
lafriks
reviewed
Jun 3, 2020
Member
Author
|
@lafriks did not work |
Member
|
oh, assert.ElementsMatch(t, reflect.ValueOf(setting.UI.ReactionsMap).MapKeys(), *a) |
Member
|
oh, I'm squared :D missing import btw ;) |
6543
force-pushed
the
api_expose-allowed-reactions
branch
from
c2435ab to
68b8b45
Compare
Member
Author
|
@lafriks now it should WORK |
mrsdizzie
reviewed
Jun 3, 2020
mrsdizzie
approved these changes
Jun 3, 2020
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Jun 4, 2020
GiteaBot
added
lgtm/done
Member
|
make lg-tm work |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* [API] Expose allowed Reactions * dont be in soutch a rush * add TEST * use ElementsMatch Co-authored-by: Lauris BH <lauris@nix.lv>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #11330
GET /settings/allowed_reactions[ "string" ]