API expose usefull General Repo settings settings#11758
Merged
lafriks merged 6 commits intoJun 10, 2020
Conversation
techknowlogick
added
the
type/enhancement
Member
|
Maybe it would be worth to add more general settings endpoint that would return json with such settings? |
GiteaBot
added
the
lgtm/need 2
Member
Author
|
@lafriks you mean GeneralRepoSettings or something like this? |
Member
|
yeah, for example |
6543
changed the title
6543
changed the title
6543
force-pushed
the
api_expose-setting-MirrorsDisabled
branch
from
8bb6f71 to
81005c8
Compare
Member
Author
|
@lafriks how do you like this? |
proton-ab
reviewed
Jun 9, 2020
proton-ab
reviewed
Jun 9, 2020
proton-ab
reviewed
Jun 9, 2020
proton-ab
reviewed
Jun 9, 2020
6543
commented
Jun 9, 2020
6543
commented
Jun 9, 2020
Co-authored-by: proton <25139420+proton-ab@users.noreply.github.com>
Member
Author
|
@proton-ab thx - do you have suggestions for other repo related instance settings witch are usefull to expose? |
mrsdizzie
reviewed
Jun 9, 2020
lafriks
approved these changes
Jun 9, 2020
GiteaBot
added
lgtm/need 1
Member
|
@6543 imho looks good :) |
Member
Author
|
@mrsdizzie will do a pull witch create a new section in swagger docs & move allowed_reactions - throu its outside of this pull scope :) |
Member
|
Sounds good! |
mrsdizzie
approved these changes
Jun 9, 2020
GiteaBot
added
lgtm/done
Member
|
🚀 |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* GeneralRepoSettings expose MirrorsDisabled, HTTPGitDisabled, MaxCreationLimit * Apply suggestions from code review Co-authored-by: proton <25139420+proton-ab@users.noreply.github.com> * lint Co-authored-by: proton <25139420+proton-ab@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as title