Backwards Compatiblety: API: Make pagination optional on GetUserMirrorRepositories #11808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
changed the title
6543
force-pushed
the
bugfix_api_opt-pagg_user-repos_11800
branch
from
4da2b80 to
e6c4a20
Compare
|
This is insecure, if users want to return all repos, then we should use @CirnoT's other PR and recommend that users who want to be insecure increase that value to size in response. |
GiteaBot
added
the
lgtm/need 2
|
a user could DOS itself ... yes but it whold happen in v1.11 too |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title close #11800