Improve label edit buttons labels#11841
Merged
Merged
Conversation
Previously when editing the buttons in the "Edit Label" modal were a strange "Update" and "No". Improved them to "Save" and "Cancel". Also fixed indentation in the template file, recommended to view changes with the "Hide whitespace changes" option enabled on GitHub.
zeripath
approved these changes
Jun 10, 2020
GiteaBot
added
the
lgtm/need 1
techknowlogick
approved these changes
Jun 11, 2020
GiteaBot
removed
the
lgtm/need 1
GiteaBot
added
the
lgtm/done
Member
|
ping LG-TM |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Improve label edit buttons labels Previously when editing the buttons in the "Edit Label" modal were a strange "Update" and "No". Improved them to "Save" and "Cancel". Also fixed indentation in the template file, recommended to view changes with the "Hide whitespace changes" option enabled on GitHub. * remove unnecessary button icon Co-authored-by: techknowlogick <techknowlogick@gitea.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when editing the buttons in the "Edit Label" modal were a strange "Update" and "No". Improved them to "Save" and "Cancel" and removed an unneccessary icon on the save button.
Also fixed indentation in the template file, recommended to view changes with the "Hide whitespace changes" option enabled on GitHub.